https://www.drupal.org/sandbox/chriscollins405/2747947

Availability Calendar Rules

The Availability Calendar Rules module allows you to set an availability calendar state using Rules. This module aims to fulfill the many requests for setting Availability Calendar states in the Availability Calendar issue queues.

I thought I had already been given permission to add modules for my other project, but apparently not!

Requirements

- Availability Calendars
- Rules

Usage

Add a new rule with the new action "Set an Availability Calendar Status".
Choose a calendar to update.
Choose a field to use as start date, or define a set date.
Choose a field to use as end date, or define a set date.
Choose a status to set.

Code location:

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/chriscollins405/2747947.git availability_calendars_rules

Comments

Collins405 created an issue. See original summary.

Collins405’s picture

Status: Active » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxchriscollins405274794...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Collins405’s picture

Status: Needs work » Needs review

Fixed errors, apart from spacing that I just cannot seem to get right. No matter what I do, the test flags it as the wrong indentation, but I have literally copied and rewritten a bit from another line that isn't flagged, and it still reports a problem. Voting to leave it as it is.

This isn't my first module, but for some reason I am having to go through the review process again. I think my last module was too simple and didn't have enough code in the module file for me to qualify!

klausi’s picture

http://pareview.sh/pareview/httpgitdrupalorgsandboxchriscollins405274794... says you are using tabs instead of spaces. Make sure to set your editor to insert spaces instead of tabs.

Collins405’s picture

@klausi Thanks mate, yeah it was a problem with notepad++. Fixed now.

visabhishek’s picture

Issue summary: View changes

Added code location : git clone --branch 7.x-1.x https://git.drupal.org/sandbox/chriscollins405/2747947.git availability_calendars_rules

visabhishek’s picture

Status: Needs review » Needs work

Hi Collins405,

1) I enabled "Availability Calendar Rules" and trying to Add a new rule with the new action "Set an Availability Calendar Status". But i am not able to find "Set an Availability Calendar Status" Action. I tried after flushing "cache all" also.
Is anything i am missing ?

2) Follow the Readme template for the readme.txt https://www.drupal.org/node/2181737

visabhishek’s picture

StatusFileSize
new54.3 KB
new27.21 KB

uploading the screen-shots

Collins405’s picture

StatusFileSize
new149.21 KB
new98.23 KB
new125.18 KB

@visabhishek Thanks for reviewing.

In the second screen shot, that looks like you are choosing an event still?

If you add an event, and then add an action, it will be there.

visabhishek’s picture

Status: Needs work » Reviewed & tested by the community

Hi Collins405,

Sorry, I was little confused with "events" and "actions". Thanks for screenshot and one more point I am suggesting you to follow readme template as i mention earlier.

Module is working fine for me and I think we dont have any blocker point. So marking as RTBC.

Collins405’s picture

Ideal, thank you. Yes OK, I will make sure I add a README in the release.

gisle’s picture

Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
The project is only 94 lines of PHP code (including comments and blanks).
Tagging with "PAReview: Single project promote".
Collins405’s picture

Any update on this project getting published?

avpaderno’s picture

Status: Reviewed & tested by the community » Needs work
/**
 * Implements hook_init().
 */
function availability_calendars_rules_init() {
  module_load_include('inc', 'availability_calendar', 'availability_calendar');
}

That file doesn't exist, which means it is missing in the repository, or that hook implementation should be removed.

I would also like to see an application with longer code. I am not sure I can say the OP understands the necessary to develop a theme/module.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.