Description

The BMI Add Ons module is a sandbox project that provides additional blocks to to the BMI module by by Azri solutions (http://drupal.org/user/115278).

It adds a number of blocks that contain forms that help to calculate various health indicators.

In addition to adding a BMI calculator geared towards users of the imperial system of measurement, the BMI Add Ons module provides the following for both users of the imperial and metric systems:

  • Basal Metabolic Rate (BMR) block (both imperial and metric)
  • Harris Benedict Formula block (applies to all users)
  • Body Fat Calculator block (both imperial and metric)
  • Waist to Hip Ratio Calculator block (both imperial and metric)

Requirements

https://www.drupal.org/project/bmi

Project page

https://www.drupal.org/sandbox/johnlawter/2761881

Git clone command

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/JohnLawter/2761881.git bmiaddons

cd bmiaddons

Manual reviews of other projects

https://www.drupal.org/node/2704941#comment-11461461
https://www.drupal.org/node/2644312#comment-11472641
https://www.drupal.org/node/2587323#comment-11476831

Comments

John Lawter created an issue. See original summary.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxJohnLawter2761881git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

John Lawter’s picture

Status: Needs work » Needs review

Corrected all issues found by pareview.sh, retested code using Coder and Coder Tough Love Modules, retested all functionality, committed to git repository.

visway12’s picture

Hi @John Lawter,

As a part of module review on drupal.org you need to do some manual reviews of projects posted by community members at https://www.drupal.org/project/issues/projectapplications

Once you reviewed some projects, you need to add URLs of reviews in this post as part of review bonus system.

For more information please check How it works and Summary section at below URL -

https://www.drupal.org/node/1975228

John Lawter’s picture

Issue summary: View changes
John Lawter’s picture

Thank you, @visway12. Thank you for the suggestion. I spent time today reviewing a module in the application queue and will continue to do more reviews as time permits.

visabhishek’s picture

Automated Review

By PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxjohnlawter2761881git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. Add hook_help
  2. Looks good and working fine form me.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

visabhishek’s picture

Status: Needs review » Reviewed & tested by the community

Module looks good and working fine for me, I think we don't have any blocker point so marking as RTBC.

John Lawter’s picture

Issue summary: View changes

Sorry, I submitted this comment in error. Too many tabs open. Ha ha.

John Lawter’s picture

I added hook_help per recommendation from visabhishek. Thank you, visabhishek!

John Lawter’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
misc’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -PAreview: review bonus

Thanks for your contribution, John Lawter !

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

John Lawter’s picture

Thank you for the update to my account and for the recommended readings, MiSc!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.