Module Description

This is a very light-weight module allows fields to be unique by bundle and language.
You can use ajax for check.
You can customize the error message

---SIMILAR MODULE----

Unique field

The unique field work on node/user/term entities and unique field ajax work on the field entity, implements ajax check ,unique per language check and custom error message and it's a very light-weight module.

Project page

https://www.drupal.org/sandbox/benellefimostfa/2773723

Git clone command

git clone --branch 8.x-1.x https://git.drupal.org/sandbox/benellefimostfa/2773723.git unique_field_ajax

Manual reviews of other projects

https://www.drupal.org/node/2684807#comment-10954405
https://www.drupal.org/node/2685727#comment-10959555
https://www.drupal.org/node/2650758#comment-10961405

Comments

benellefimostfa created an issue. See original summary.

PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxbenellefimostfa27737...

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

benellefimostfa’s picture

Status: Needs work » Needs review

Errors fixed

visabhishek’s picture

Status: Needs review » Needs work

Automated Review

PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxbenellefimostfa2773723git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) Not working for me. I am attaching the screenshot. Is anything i am missing if yes then comment and also update in readme configration.
  2. (+) Use 4 space indentation in composer file.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

benellefimostfa’s picture

"(*) Not working for me. I am attaching the screenshot. Is anything i am missing if yes then comment and also update in readme configration."

Thank you for your review but what's not working for you and where is the screenshot?
Thanks.

benellefimostfa’s picture

Maybe you have missed that the field must be required and one of this type
('string','list_string','text','email','entity_reference','path','uri')

I have added this to the readme.txt

benellefimostfa’s picture

Status: Needs work » Needs review
visabhishek’s picture

Status: Needs review » Needs work

Thanks benellefimostfa.

Now all good and working fine for me.

Only one scenario its not working :
Steps are as follow:

1: Add Field named "foo"
2: Set as required
3: Check for Unique and Use ajax
4: Fill Some error message

Now try to add new node :
1: Click on create node link
2: Fill some value in "foo" field (But don't press tab or Enter keys)
3: Click on "Save and publish" button

For me its throwing required error message for "foo" field and "foo" filed is blank now.

benellefimostfa’s picture

Status: Needs work » Active
benellefimostfa’s picture

Status: Active » Needs review

I have created a custom event based on keyup

visabhishek’s picture

Status: Needs review » Reviewed & tested by the community

Its working fine for me. I dont think we have any blocker , So i am marking as RTBC.

benellefimostfa’s picture

Priority: Normal » Major
mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, benellefimostfa! You are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. We know it's broken and are trying to fix it.

benellefimostfa’s picture

Thank you mlncn and visabhishek for your review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.