This module allows a user to delete his/her account or deactivate it temporarily. A user can choose the time period option for which the account will stay deactivated. These options are configurable. The account will stay inactive for the selected time period.

FEATURES:

1. Configurable time period options for which user account can be deactivated.
2. Setting to either keep/disable the content (nodes, comments) after the
account has been deactivated.
3. The "Deactivate account form" can either be shown at a normal menu link or a
local tab under user profile. This option is configurable.
4. A menu path has to be provided if the "Deactivate account form" is set to be
displayed as per menu.
5. The user can be redirected to a configurable path after the account is
deactivated or deleted.

Project page:https://www.drupal.org/sandbox/anandtoshniwal/2779019
Git url: git clone --branch 7.x-1.x https://git.drupal.org/sandbox/anandtoshniwal/2779019.git deactivate_account

Manual review of other projects:

  1. https://www.drupal.org/node/2778751#comment-11582921
  2. https://www.drupal.org/node/2771627#comment-11583753
  3. https://www.drupal.org/node/2796023#comment-11592381
CommentFileSizeAuthor
#11 no-validation.png48.57 KBvisabhishek
#11 Wrong-user.png28.03 KBvisabhishek
Screen Shot 2016-08-22 at 3.54.48 pm.png59.76 KBanand.toshniwal93

Comments

anand.toshniwal93 created an issue. See original summary.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue summary: View changes
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue tags: -user, -authorization
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue summary: View changes
manojbisht_drupal’s picture

manojbisht_drupal commented
Status: Needs review » Needs work

There are couple of Error:

1. For First time when clicking on "Add More" in configuration page, gives error for "Redirect Path is required".
2. When clicking on "Add More" 3-4 times, 3-4 textfield opens up, which is good, if I submit the form, by entering the value in only one textfield, and remaining 3 other textfield empty, then after saving the form, it still shows me 4 textfield, instead of only one textfield, which is filled.
3. There are 2 forms on user profile page under deactivate account tab, choosing one radio button, and clicking on submit, ask for password, which is part of other form.
4. More Description to the configuration menu link, and on hour textfield with example, will be gud for user point of view, as it takes time to check in which format time has to be entered.

mlevasseur’s picture

mlevasseur commented
Title: Deactivate Account » [D7] Deactivate Account
sneha_surve’s picture

sneha_surve commented

Hi Anand,

If there is no hours set from backend for deactivation of account, Time field is showing radio button with no hours specified. Also, Time field in backend must be required field, if they are left empty than we are getting notice as undefined index.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Status: Needs work » Needs review

Hi @manojbisht_drupal, @sneha_surve,

Thanks for reviewing and pointing out errors. I have fixed those errors.
@manojbisht_drupal: There is a single form on user profile page under deactivate account tab which contains two fieldset and it is purposefully kept to ask password as confirmation from the user.

@sneha_surve : Now if there is no hours set from backend for deactivation of an account then deactivate account fieldset won't be visible to users.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

visabhishek’s picture

visabhishek commented
Status: Needs review » Needs work

Automated Review

Please fix Error reported By PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxanandtoshniwal2779019git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) I am trying to set deactivate configration for other user using admin login, Then its not working. I am attaching the screenshot, if i am missing something Please update the readme.
  2. (+) We can validate for number on deactivate configration form. Screenshot attached .

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

visabhishek’s picture

visabhishek commented
StatusFileSize
new Wrong-user.png28.03 KB
new no-validation.png48.57 KB
anand.toshniwal93’s picture

anand.toshniwal93 commented

@visabhishek

Thanks for reviewing.
admin cannot deactivate other users account. This module enables admin to set different time period options from which a user can choose the time period option for which the account will stay deactivated.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Status: Needs work » Needs review
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue summary: View changes
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue summary: View changes
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue summary: View changes
anand.toshniwal93’s picture

anand.toshniwal93 commented
Issue tags: +PAreview: review bonus
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) No Major Findings
  2. (+) No Release blocker
  3. Just a recommendation
  4. ...]

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Reviewed & tested by the community

Module looks fine for me & there are no security issues.
This will definitely go to RTBC now.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Priority: Normal » Major

Updating issue status to major.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Priority: Major » Critical
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

I will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.