Coming from #2945093-34: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets #1

This is a pure test refactoring.

CommentFileSizeAuthor
#6 2949136-5.patch25.63 KBgabesullice
#6 interdiff-original-5.txt1.16 KBgabesullice
refactor-assert_resource_response.patch25.64 KBgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
Parent issue: » #2945093: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets
gabesullice’s picture

gabesullice
Primary language English
commented
Title: Refactor function test assertResourceResponse to be more flexible. » Refactor assertResourceResponse test method to be more flexible.
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

I already reviewed this in detail at #2945093-34: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets.

Looks lovely ❤️, but my two nits haven't been fixed yet.

  1. +++ b/tests/src/Functional/ResourceTestBase.php
@@ -428,8 +428,9 @@ abstract class ResourceTestBase extends BrowserTestBase {
+   *   The expected document or NULL if there should be not be a response body.

    See #2945093-34: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets.2. 

  2. +++ b/tests/src/Functional/ResourceTestBase.php
@@ -460,8 +461,14 @@ abstract class ResourceTestBase extends BrowserTestBase {
+          $this->assertTrue(is_null($response_document));

    See #2945093-34: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets.3.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +blocker

This is a blocker for #2945093: Comprehensive JSON API integration test coverage phase 3: test JSON API-specific use cases: related/relationship routes, includes and sparse field sets.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-original-5.txt1.16 KB
new 2949136-5.patch25.63 KB

D'oh!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

:)

Queueing test against 8.6 too. RTBC if green.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.