Add missing getter method to retrieve range (limit/offset) from Select query objects

Good catch, probably this will need some kind of test to ensure that this behavior works? A kernel-test would be the perfect place for this. I can't see any kind of test for ranges in core/tests/Drupal/Tests/Core/Database which is where this should probably end up.

Since there is no test for ranges currently, we could probably get away with not adding a test and doing that in a followup instead.

This is the Bug Smash Initiatives target today.

I've verified that this feature is not present in latest drupal codebase

In https://git.drupalcode.org/project/drupal/-/blob/main/core/lib/Drupal/Co... or
https://git.drupalcode.org/project/drupal/-/blob/main/core/lib/Drupal/Co...

I'm not sure if this should perhaps be reclassified as a Feature request.

Looks like all that is required here would be some testing.

Note based on the documentation of the other getters the comment could probably do with updating to match the same style.

Built the fork and added two Kernal tests. Everything is running green. I tested locally with these commands:

PHPSTAN:
ddev exec vendor/bin/phpstan analyse \
-c core/phpstan.neon.dist \
core/tests/Drupal/KernelTests/Core/Database/SelectGetRangeTest.php

PHPCS:
ddev exec vendor/bin/phpcs --standard=Drupal core/tests/Drupal/KernelTests/Core/Database/SelectGetRangeTest.php

PHPCBF:
ddev exec vendor/bin/phpcbf --standard=Drupal core/tests/Drupal/KernelTests/Core/Database/SelectGetRangeTest.php

Run test:
ddev exec bash -c '
export SIMPLETEST_DB="mysql://db:db@db/db"
export SIMPLETEST_BASE_URL="http://web"
export BROWSERTEST_OUTPUT_DIRECTORY="sites/simpletest/browser_output"
mkdir -p sites/simpletest/browser_output
chmod -R a+w sites/simpletest
vendor/bin/phpunit -c core/phpunit.xml.dist core/tests/Drupal/KernelTests/Core/Database/SelectGetRangeTest.php
'

Thanks for your work on this. Great work updating issue summary.

I'm flipping back to Needs Work as I think this will probably need a change record?

>Yes — adds a new public method to Select.
https://www.drupal.org/about/core/policies/core-change-policies/change-r... -> An API change

I also wonder if we need to ensure the documentation is consistent across the methods in the Select Interface.
namely:

compare these lines:

   * Returns a reference to the tables array for this query.
   * Because this method returns by reference, alter hooks may edit the tables ...
   * Note that this method must be called by reference as well:"

I have added a change record. It is my first time, so I would appreciate someone to review it.

https://www.drupal.org/node/3574425

The change record looks great

I agree.

While checking change records I saw that the one here was published although the issue has not been committed. So, I have returned it to a draft state. Also, the version and branch are incorrect and should be updated.

> Return NULL if no range is set

Updated the function to return null when no range is set. This is following instructions in the summary.

Believe CR matches the solution. Did update branch for main as this is an API change that not sure which 11.x branch will land in

Test coverage can be seen here https://git.drupalcode.org/issue/drupal-2986699/-/jobs/9031886
Did rebase to trigger a new pipeline that I can rerun as a Reporter role.

Took a crack at credit while I was at it. Believe this one is good to go.

Committed/pushed to main and 11.x, thanks!