Needs work
Project:
Data
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Oct 2019 at 12:17 UTC
Updated:
1 Oct 2021 at 17:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
abrammComment #3
abrammChecking it now.
Comment #4
abrammThe src/Table.php file seems to be not used at all. Not sure why it even exists.
It may be worth reviewing the whole module code to identify dead parts.
Comment #5
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.
Comment #6
suresh prabhu parkala commentedPlease review the patch file. Solved Drupal9 readiness. Thank you
Comment #7
BalajiDS commented@Suresh Prabhu Parkala, Please change the line before apply patch #6, "core_version_requirement: 8^ || 9^" into "core_version_requirement: ^8 || ^9".
After changes done in patch #6 and applied please add the line "core_version_requirement: ^8 || ^9" in data_search.info.yml
Comment #8
suresh prabhu parkala commentedSorry about that. Here is the updated patch please review.
Comment #9
BalajiDS commentedpatch #8 works fine.
Thanks, @Suresh Prabhu Parkala
Comment #10
andriyun commentedSince we have patches related to general module Drupal 9 readiness it make sense to update issue summary
Comment #11
andriyun commentedAfter I applied patch #8 I see following deprecation notices in project
These notices are harmless.
It looks like legacy code from Drupal 7 version.
But I think it still should be taken care
Comment #12
karishmaamin commentedFixed deprecation in #11. Please review
Comment #13
veronicaseveryn commentedI have added more fixes for deprecated items based on #12 initial changes.