Problem/Motivation

There is one single left test failure. It is due to the fact that there is still no support for a batch drush run. Let's consider this as a future request. Anyway, this is the output:

There was 1 failure:

1) Drupal\Tests\devel_generate_commerce\Functional\CommerceDevelGenerateCommandTest::testDrushGenerateCommand
devel-generate:commerce batch ending message not found
Failed asserting that '' contains "finished 55 elements created successfully.".

Steps to reproduce

Run the test: 1.0.x-dev test with PHP 8.0 & MySQL 5.7, Drupal 9.3.x

Proposed resolution

Remove these lines:

$messages = $this->getErrorOutput();
$this->assertStringContainsStringIgnoringCase('Finished 55 elements created successfully.', $messages, 'devel-generate:commerce batch ending message not found');

from tests/src/Functional/CommerceDevelGenerateCommandTest.php

Remaining tasks

Write a proper fix. Run tests locally. Push a new release tag (I just want a normal stable release).

User interface changes

No.

API changes

No.

Data model changes

No.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andrei.vesterli created an issue. See original summary.

andrei.vesterli’s picture

Assigned: andrei.vesterli » nick.murza
Status: Active » Needs review

mrkolea made their first commit to this issue’s fork.

nick.murza’s picture

Assigned: nick.murza » Unassigned
Status: Needs review » Fixed

Looks good for me. Merged.

andrei.vesterli’s picture

Status: Fixed » Closed (fixed)

Moved to the next release.