Problem/Motivation

Currently only use STATUS message type.

Please allow different message types:

  • STATUS
  • WARNING
  • ERROR

(see: \Drupal\Core\Messenger\MessengerInterface)

CommentFileSizeAuthor
#8 reroll_diff_3-8.txt7.05 KBvighneshh
#8 message-type-3302137-8.patch9.24 KBvighneshh
#4 Screenshot from 2022-08-17 12-29-51.png17.83 KBomkar-pd
#4 Screenshot from 2022-08-17 12-25-04.png40.26 KBomkar-pd
#3 message-type-3302137-3.patch3.08 KBomkar-pd

Comments

nevergone created an issue. See original summary.

nevergone’s picture

nevergone
Primary language Hungarian
commented
Issue summary: View changes
omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
StatusFileSize
new message-type-3302137-3.patch3.08 KB

Added select list in setting form for the message type.
the default message type is selected to status.

Options:

  1. Status
  2. Warning
  3. Error
omkar-pd’s picture

omkar-pd commented
StatusFileSize
new Screenshot from 2022-08-17 12-25-04.png40.26 KB
new Screenshot from 2022-08-17 12-29-51.png17.83 KB
nevergone’s picture

nevergone
Primary language Hungarian
commented
Issue tags: +Needs tests

Please add test.

omkar-pd’s picture

omkar-pd commented

No idea about writing test cases, hope someone else adds tests,

vighneshh’s picture

vighneshh commented
Assigned: Unassigned » vighneshh

Will work on adding few tests

vighneshh’s picture

vighneshh commented
Assigned: vighneshh » Unassigned
StatusFileSize
new message-type-3302137-8.patch9.24 KB
new reroll_diff_3-8.txt7.05 KB

Added message type related config tests
please review.
Also adding an interdff between the #3 patch and my new patch.

  • nevergone committed ed7aa05 on 8.x-1.x 
    Issue #3302137 by omkar-pd, Vighneshh, nevergone: Logout message type
nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Commited with test refactoring, thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.