Skip to content

feat: DATE and DOUBLE support more input formats #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephaniewang526 merged 1 commit into from
Nov 9, 2021
Merged

feat: DATE and DOUBLE support more input formats #1397

stephaniewang526 merged 1 commit into from
Nov 9, 2021

Conversation

@burakgok
Copy link
Contributor

@burakgok burakgok commented Nov 3, 2021

Fixes #1396

  1. Long values are converted into Integer for DATE fields.
  2. Date literals are converted into epoch days (Integer) for DATE fields.
  3. Number values are converted into Double for DOUBLE fields.

@burakgok burakgok requested review from a team and stephaniewang526 November 3, 2021 10:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Nov 3, 2021
@burakgok burakgok changed the title DATE and DOUBLE support more input formats feat: DATE and DOUBLE support more input formats Nov 3, 2021
@yirutang
Copy link
Contributor

yirutang commented Nov 3, 2021

Looks great! Could you add unit test for the extra cases supported?
Date with String
Date with Long
Double with Integer

@burakgok burakgok requested a review from a team as a code owner November 4, 2021 10:23
@burakgok burakgok force-pushed the main branch 2 times, most recently from 6fedc37 to 89a5835 Compare November 4, 2021 16:58
yirutang
yirutang approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2021
@stephaniewang526 stephaniewang526 removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 5, 2021
@burakgok
feat: DATE and DOUBLE support more input formats
4f7c9a6 
1. Long values are converted into Integer for DATE fields.
2. Date literals are converted into epoch days (Integer) for DATE fields.
3. Number values are converted into Double for DOUBLE fields.
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2021
@stephaniewang526 stephaniewang526 merged commit 9c8dc0a into googleapis:main Nov 9, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 15, 2021
@release-please
chore: release 2.6.0 (#1403)
30939c8 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.5.1...v2.6.0) (2021-11-15)


### Features

* add support for StorageError ([#1391](https://www.github.com/googleapis/java-bigquerystorage/issues/1391)) ([176dc8b](https://www.github.com/googleapis/java-bigquerystorage/commit/176dc8b1fa30cf9a9a98628bd83c9ab487ddb094))
* DATE and DOUBLE support more input formats ([#1397](https://www.github.com/googleapis/java-bigquerystorage/issues/1397)) ([9c8dc0a](https://www.github.com/googleapis/java-bigquerystorage/commit/9c8dc0aabb471fdb8580f434cc5a66bad585e8f2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#1406](https://www.github.com/googleapis/java-bigquerystorage/issues/1406)) ([38f5eb9](https://www.github.com/googleapis/java-bigquerystorage/commit/38f5eb9788e1f090c0034a789a512dcec2384fdb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yirutang yirutang yirutang approved these changes

+1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DATE and DOUBLE should support more input formats

4 participants

@burakgok @yirutang @stephaniewang526 @yoshi-kokoro