Skip to content

Conversation

@kmjung
Copy link
Contributor

@kmjung kmjung commented Jul 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #418 ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #419 into master will increase coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
+ Coverage     77.19%   77.36%   +0.17%     
- Complexity      565      574       +9     
============================================
  Files            55       55              
  Lines          3367     3367              
  Branches        201      198       -3     
============================================
+ Hits           2599     2605       +6     
  Misses          659      659              
+ Partials        109      103       -6     
Impacted Files Coverage Δ Complexity Δ
...rage/v1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)
...v1beta1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)
...v1beta2/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a27c5f...a3d6ae0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadRows does not retry on all transient HTTP/2 failures

3 participants