Skip to content

Conversation

@stephaniewang526
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@stephaniewang526 stephaniewang526 requested a review from a team September 22, 2020 17:38
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner September 22, 2020 17:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #551   +/-   ##
=========================================
  Coverage     78.65%   78.65%           
  Complexity      663      663           
=========================================
  Files            59       59           
  Lines          3786     3786           
  Branches        253      253           
=========================================
  Hits           2978     2978           
  Misses          692      692           
  Partials        116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b7e3a...2b53b7d. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want this as samples(deps): update arrow-vector to v1. Otherwise, an update will tell release-please to bump the client version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants