Skip to content

fix: make placeholder class public #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 3 commits into from
Dec 2, 2021
Merged

fix: make placeholder class public #1085

gcf-merge-on-green merged 3 commits into from
Dec 2, 2021

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Dec 2, 2021

Currently javadoc build is failing:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project google-cloud-bigtable-stats: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - javadoc: error - No public or protected classes found to document.

@kolea2 kolea2 requested a review from a team as a code owner December 2, 2021 21:22
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Dec 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2021
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 879377a into main Dec 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the javadoc-fix branch December 2, 2021 21:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 6, 2021
@release-please
chore: release 2.3.1 (#1086)
8a01acf 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.1](https://www.github.com/googleapis/java-bigtable/compare/v2.3.0...v2.3.1) (2021-12-03)


### Bug Fixes

* add placeholder class for bigtable-stats ([#1075](https://www.github.com/googleapis/java-bigtable/issues/1075)) ([9d9f575](https://www.github.com/googleapis/java-bigtable/commit/9d9f57556216becfeb302bfaf5a4f35a9b73b611))
* add status label to gfe metrics ([#1077](https://www.github.com/googleapis/java-bigtable/issues/1077)) ([777549e](https://www.github.com/googleapis/java-bigtable/commit/777549e6ac64a03c9bd67d6b5a5cf4819ba8656f))
* make placeholder class public ([#1085](https://www.github.com/googleapis/java-bigtable/issues/1085)) ([879377a](https://www.github.com/googleapis/java-bigtable/commit/879377a03b86aa9a1f1035245c290ec78501b2cd))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#1087](https://www.github.com/googleapis/java-bigtable/issues/1087)) ([f290ce7](https://www.github.com/googleapis/java-bigtable/commit/f290ce74f6b803b8c5786e8b4c69b9efa6995c59))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mutianf mutianf mutianf approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2 @mutianf