fix: plain text when testing emulator connection #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses plain text, instead of ssl when testing for local connections.
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
============================================
- Coverage 85.12% 85.10% -0.02%
+ Complexity 2627 2623 -4
============================================
Files 155 155
Lines 14369 14374 +5
Branches 1340 1340
============================================
+ Hits 12231 12233 +2
- Misses 1571 1573 +2
- Partials 567 568 +1
Continue to review full report at Codecov.
|
olavloite
approved these changes
Mar 30, 2021
Collaborator
olavloite
left a comment
There was a problem hiding this comment.
Thanks for noticing that one!
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.11](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.7.10...v2.7.11) (2022-10-20) ### Dependencies * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.16 ([googleapis#1017](https://togithub.com/googleapis/java-spanner-jdbc/issues/1017)) ([ee7888c](https://togithub.com/googleapis/java-spanner-jdbc/commit/ee7888c1720aa84ca2d4278a9e52f111c298ea9d)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.16 ([googleapis#1018](https://togithub.com/googleapis/java-spanner-jdbc/issues/1018)) ([3d5b100](https://togithub.com/googleapis/java-spanner-jdbc/commit/3d5b1004eb3d4e61f954b523ef2c45d59f0fbfe0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses plain text, instead of ssl when testing for local connections. This fixes connection checks when using the
MockSpannerServiceImpland it works with the emulator as well.Without this fix we would get a transport error when testing the
getConnectionwhen using theMockSpannerServiceImpl, since the client would expectTLS, while the server would be servingplainText.