fix: allow partial streaming_buffer statistics #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the BQ backend would supply all fields of the streamingBuffer statistics or none. This is no longer the case, so we relax construction to not depend on all values being present. Related: internal issue b/148720220
plamut
reviewed
Feb 14, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
LGTM.
The coverage failure seems legitimate, should be fixed.
stephaniewang526
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the BQ backend would supply all fields of the
streamingBuffer statistics or none. This is no longer the
case, so we relax construction to not depend on all values
being present.
Related: internal issue b/148720220