From 5836a653373a382ee3d3b287ab5377230852a554 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 13 Mar 2023 19:13:35 -0400 Subject: [PATCH v2 5/6] Don't create useless TableAttachInfo objects. It's silly to create a TableAttachInfo object that we're not going to dump, when we know perfectly well at creation time that it won't be dumped. Discussion: https://postgr.es/m/1376149.1675268279@sss.pgh.pa.us --- src/bin/pg_dump/common.c | 3 ++- src/bin/pg_dump/pg_dump.c | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c index 44558b60e8..df48d0bb17 100644 --- a/src/bin/pg_dump/common.c +++ b/src/bin/pg_dump/common.c @@ -336,7 +336,8 @@ flagInhTables(Archive *fout, TableInfo *tblinfo, int numTables, } /* Create TableAttachInfo object if needed */ - if (tblinfo[i].dobj.dump && tblinfo[i].ispartition) + if ((tblinfo[i].dobj.dump & DUMP_COMPONENT_DEFINITION) && + tblinfo[i].ispartition) { TableAttachInfo *attachinfo; diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 7f40b455af..a4a06b4a20 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -16120,9 +16120,6 @@ dumpTableAttach(Archive *fout, const TableAttachInfo *attachinfo) if (dopt->dataOnly) return; - if (!(attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION)) - return; - q = createPQExpBuffer(); if (!fout->is_prepared[PREPQUERY_DUMPTABLEATTACH]) -- 2.31.1