*** pgsql/src/backend/utils/adt/ruleutils.c 2008/01/06 01:03:31 1.207.2.8 --- pgsql/src/backend/utils/adt/ruleutils.c 2008/06/06 17:59:53 1.207.2.9 *************** *** 3,9 **** * back to source text * * IDENTIFICATION ! * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.207.2.7 2007/10/13 15:55:58 tgl Exp $ * * This software is copyrighted by Jan Wieck - Hamburg. * --- 3,9 ---- * back to source text * * IDENTIFICATION ! * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.207.2.8 2008/01/06 01:03:31 tgl Exp $ * * This software is copyrighted by Jan Wieck - Hamburg. * *************** get_const_expr(Const *constval, deparse_ *** 4042,4051 **** * * In reality we only need to defend against infinity and NaN, * so we need not get too crazy about pattern matching here. */ if (strspn(extval, "0123456789+-eE.") == strlen(extval)) { ! appendStringInfoString(buf, extval); if (strcspn(extval, "eE.") != strlen(extval)) isfloat = true; /* it looks like a float */ } --- 4042,4060 ---- * * In reality we only need to defend against infinity and NaN, * so we need not get too crazy about pattern matching here. + * + * There is a special-case gotcha: if the constant is signed, + * we need to parenthesize it, else the parser might see a + * leading plus/minus as binding less tightly than adjacent + * operators --- particularly, the cast that we might attach + * below. */ if (strspn(extval, "0123456789+-eE.") == strlen(extval)) { ! if (extval[0] == '+' || extval[0] == '-') ! appendStringInfo(buf, "(%s)", extval); ! else ! appendStringInfoString(buf, extval); if (strcspn(extval, "eE.") != strlen(extval)) isfloat = true; /* it looks like a float */ }