diff options
| author | Bruce Momjian | 2003-10-09 13:38:05 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2003-10-09 13:38:05 +0000 |
| commit | 1dad866bb47c1ab733015abba2f5d8a852279774 (patch) | |
| tree | e31cb05d90fb7f88f76221f4fe097f486fd5796f | |
| parent | 668715258203830db182a03dca0e4891c5a3f9d6 (diff) | |
Someone report me small bug in contrib/pg_dumplo today. It's problem
with a little dirty snprintf() usage which I used some years ago:
snprintf(path, BUFSIZ, "%s/lo_dump.index", path);
Karel Zak
| -rw-r--r-- | contrib/pg_dumplo/utils.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/contrib/pg_dumplo/utils.c b/contrib/pg_dumplo/utils.c index 288e312f3e2..091946be6f2 100644 --- a/contrib/pg_dumplo/utils.c +++ b/contrib/pg_dumplo/utils.c @@ -1,7 +1,7 @@ /* ------------------------------------------------------------------------- * pg_dumplo * - * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.6 2002/09/05 21:01:16 tgl Exp $ + * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.7 2003/10/09 13:38:05 momjian Exp $ * * Karel Zak 1999-2000 * ------------------------------------------------------------------------- @@ -30,6 +30,7 @@ void index_file(LODumpMaster * pgLO) { char path[BUFSIZ]; + int sz; if (pgLO->action == ACTION_SHOW) return; @@ -49,7 +50,8 @@ index_file(LODumpMaster * pgLO) } } - snprintf(path, BUFSIZ, "%s/lo_dump.index", path); + sz = strlen(path); + strncat(path, "/lo_dump.index", BUFSIZ-sz); if ((pgLO->index = fopen(path, "w")) == NULL) { @@ -60,8 +62,8 @@ index_file(LODumpMaster * pgLO) } else if (pgLO->action != ACTION_NONE) { - - snprintf(path, BUFSIZ, "%s/lo_dump.index", path); + sz = strlen(path); + strncat(path, "/lo_dump.index", BUFSIZ-sz); if ((pgLO->index = fopen(path, "r")) == NULL) { |