diff options
| author | Jeff Davis | 2025-03-06 07:07:25 +0000 |
|---|---|---|
| committer | Jeff Davis | 2025-03-06 07:07:25 +0000 |
| commit | 298944e8d80252820531309e5b73d7de7d85e2df (patch) | |
| tree | 9b943e036f7724dd78320eb6fe0cbd7e2bd4db64 | |
| parent | 39de4f157d3ac0b889bb276c2487fe160578f967 (diff) | |
Address stats import review comments.
Reported-by: jian he <[email protected]>
Discussion: https://postgr.es/m/CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com
| -rw-r--r-- | src/backend/statistics/relation_stats.c | 8 | ||||
| -rw-r--r-- | src/backend/statistics/stat_utils.c | 10 |
2 files changed, 7 insertions, 11 deletions
diff --git a/src/backend/statistics/relation_stats.c b/src/backend/statistics/relation_stats.c index 2c1cea3fc80..52dfa477187 100644 --- a/src/backend/statistics/relation_stats.c +++ b/src/backend/statistics/relation_stats.c @@ -127,13 +127,7 @@ relation_statistics_update(FunctionCallInfo fcinfo) ctup = SearchSysCache1(RELOID, ObjectIdGetDatum(reloid)); if (!HeapTupleIsValid(ctup)) - { - ereport(WARNING, - (errcode(ERRCODE_OBJECT_IN_USE), - errmsg("pg_class entry for relid %u not found", reloid))); - table_close(crel, RowExclusiveLock); - return false; - } + elog(ERROR, "pg_class entry for relid %u not found", reloid); pgcform = (Form_pg_class) GETSTRUCT(ctup); diff --git a/src/backend/statistics/stat_utils.c b/src/backend/statistics/stat_utils.c index 54ead90b5bb..9647f5108b3 100644 --- a/src/backend/statistics/stat_utils.c +++ b/src/backend/statistics/stat_utils.c @@ -136,12 +136,14 @@ stats_lock_check_privileges(Oid reloid) /* * For indexes, we follow the locking behavior in do_analyze_rel() and - * check_inplace_rel_lock(), which is to lock the table first in - * ShareUpdateExclusive mode and then the index in AccessShare mode. + * check_lock_if_inplace_updateable_rel(), which is to lock the table + * first in ShareUpdateExclusive mode and then the index in AccessShare + * mode. * * Partitioned indexes are treated differently than normal indexes in - * check_inplace_rel_lock(), so we take a ShareUpdateExclusive lock on - * both the partitioned table and the partitioned index. + * check_lock_if_inplace_updateable_rel(), so we take a + * ShareUpdateExclusive lock on both the partitioned table and the + * partitioned index. */ switch (get_rel_relkind(reloid)) { |