diff options
| author | Heikki Linnakangas | 2013-07-17 17:24:28 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2013-07-17 17:37:09 +0000 |
| commit | 3f2adace1ec025908b5189f0773b4eaab3d228d5 (patch) | |
| tree | e2d01bec6ce78b1a59b079e76ff3f67569a0e35a | |
| parent | 750f43685b1b88d4281074940cdcea0e328593aa (diff) | |
Fix end-of-loop optimization in pglz_find_match() function.
After the recent pglz optimization patch, the next/prev pointers in the
hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
entries instead. The end-of-loop check in pglz_find_match() function didn't
get the memo. The result was the same from a correctness point of view, but
because the NULL-check would never fail, the tiny optimization turned into
a pessimization.
Reported by Stephen Frost, using Coverity scanner.
| -rw-r--r-- | src/backend/utils/adt/pg_lzcompress.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/pg_lzcompress.c b/src/backend/utils/adt/pg_lzcompress.c index ae6751929e3..1c129b800b3 100644 --- a/src/backend/utils/adt/pg_lzcompress.c +++ b/src/backend/utils/adt/pg_lzcompress.c @@ -466,7 +466,7 @@ pglz_find_match(int16 *hstart, const char *input, const char *end, * Be happy with lesser good matches the more entries we visited. But * no point in doing calculation if we're at end of list. */ - if (hent) + if (hent != INVALID_ENTRY_PTR) { if (len >= good_match) break; |