summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Eisentraut2022-10-08 11:41:18 +0000
committerPeter Eisentraut2022-10-08 11:43:26 +0000
commite4c61bedcb791fe79fdc4e96a3a7ab59b0dbacaf (patch)
tree862b0969a73d8f614bbd7d05d76fa17c29ee4b9c
parent2473cb9ff374dff99437138c144fab6d9f7dfd26 (diff)
Use fabsf() instead of Abs() or fabs() where appropriate
This function is new in C99. Reviewed-by: Zhang Mingli <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/4beb42b5-216b-bce8-d452-d924d5794c63%40enterprisedb.com
-rw-r--r--contrib/btree_gist/btree_float4.c2
-rw-r--r--contrib/intarray/_int_gist.c2
-rw-r--r--contrib/seg/seg.c5
-rw-r--r--src/backend/utils/adt/float.c2
4 files changed, 6 insertions, 5 deletions
diff --git a/contrib/btree_gist/btree_float4.c b/contrib/btree_gist/btree_float4.c
index 3cbd9a06dcc..84ca5eee501 100644
--- a/contrib/btree_gist/btree_float4.c
+++ b/contrib/btree_gist/btree_float4.c
@@ -102,7 +102,7 @@ float4_dist(PG_FUNCTION_ARGS)
if (unlikely(isinf(r)) && !isinf(a) && !isinf(b))
float_overflow_error();
- PG_RETURN_FLOAT4(Abs(r));
+ PG_RETURN_FLOAT4(fabsf(r));
}
diff --git a/contrib/intarray/_int_gist.c b/contrib/intarray/_int_gist.c
index f67699bfccc..331fa25fcf7 100644
--- a/contrib/intarray/_int_gist.c
+++ b/contrib/intarray/_int_gist.c
@@ -540,7 +540,7 @@ g_int_picksplit(PG_FUNCTION_ARGS)
union_d = inner_int_union(datum_r, datum_alpha);
rt__int_size(union_d, &size_beta);
pfree(union_d);
- costvector[i - 1].cost = fabs((size_alpha - size_l) - (size_beta - size_r));
+ costvector[i - 1].cost = fabsf((size_alpha - size_l) - (size_beta - size_r));
}
qsort((void *) costvector, maxoff, sizeof(SPLITCOST), comparecost);
diff --git a/contrib/seg/seg.c b/contrib/seg/seg.c
index 9b58675266a..e964560053d 100644
--- a/contrib/seg/seg.c
+++ b/contrib/seg/seg.c
@@ -10,6 +10,7 @@
#include "postgres.h"
#include <float.h>
+#include <math.h>
#include "access/gist.h"
#include "access/stratnum.h"
@@ -706,7 +707,7 @@ rt_seg_size(SEG *a, float *size)
if (a == (SEG *) NULL || a->upper <= a->lower)
*size = 0.0;
else
- *size = (float) Abs(a->upper - a->lower);
+ *size = fabsf(a->upper - a->lower);
}
Datum
@@ -714,7 +715,7 @@ seg_size(PG_FUNCTION_ARGS)
{
SEG *seg = PG_GETARG_SEG_P(0);
- PG_RETURN_FLOAT4((float) Abs(seg->upper - seg->lower));
+ PG_RETURN_FLOAT4(fabsf(seg->upper - seg->lower));
}
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
index fc8f39a7a98..da97538ebe3 100644
--- a/src/backend/utils/adt/float.c
+++ b/src/backend/utils/adt/float.c
@@ -593,7 +593,7 @@ float4abs(PG_FUNCTION_ARGS)
{
float4 arg1 = PG_GETARG_FLOAT4(0);
- PG_RETURN_FLOAT4((float4) fabs(arg1));
+ PG_RETURN_FLOAT4(fabsf(arg1));
}
/*