From: fxn@... Date: 2021-05-22T17:29:39+00:00 Subject: [ruby-core:103985] [Ruby master Feature#17881] Add a Module#const_added callback Issue #17881 has been updated by fxn (Xavier Noria). > If I'm not mistaken, such usage could cause the TracePoint to stay active at runtime, which isn't a huge deal, but will still trigger every time a singleton_class or anonymous class is created, which isn't a good practice at runtime, but that I nonetheless see happen. Yes, that is right. Is in that sense that I said _normally_. You'd need someone to not eager load anything, and to have explicit namespaces in the non eager loaded subtree. It is a possibility, but I'd believe should be rare. Rare enough not to be your main design driver. > But again all this is hard to quantify and a bit "handwavy". I believe the cleanliness of the API alone should be the main argument Agree, and I believe it is core's call to decide if that is cleaner, perhaps Zeitwerk's usage of TP is already "clean" in their opinion. I do not know :). ---------------------------------------- Feature #17881: Add a Module#const_added callback https://bugs.ruby-lang.org/issues/17881#change-92118 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal ---------------------------------------- ### Use case Autoloaders like `zeitwerk` need a callback when a new class or module is registered in the constant table. Currently this is implemented with TracePoint's `:class` event. It works, but it is a bit unfortunate to have to use an API intended for debugging to implement production features. It doesn't feel "conceptually clean". It also [doesn't play well with MJIT](https://k0kubun.medium.com/ruby-3-jit-can-make-rails-faster-756310f235a), even though it's more of an MJIT limitation. Additionally this usage of TracePoint cause [some incompatibilities with some debuggers like `byebug`](https://github.com/deivid-rodriguez/byebug/issues/564) (even though others don't have this issue). ### Proposal I believe that if Ruby was to call `Module#const_added` when a constant is registered, Zeitwerk could get rid of TracePoint. For now I implemented it as: `const_added(const_name)` for similarity with `method_added`. But maybe it could make sense to have the signature be `const_added(const_name, const_value)`. Also since `method_removed` exists, maybe `const_removed` would need to be added for consistency. ### Links Patch: https://github.com/ruby/ruby/pull/4521 Zeitwerk side discussion: https://github.com/fxn/zeitwerk/issues/135 cc @k0kubun -- https://bugs.ruby-lang.org/ Unsubscribe: