From: "nobu (Nobuyoshi Nakada) via ruby-core" <ruby-core@...>
Date: 2023-10-26T04:21:40+00:00
Subject: [ruby-core:115175] [Ruby master Bug#19362] #dup on Proc doesn't call initialize_dup

Issue #19362 has been updated by nobu (Nobuyoshi Nakada).


I've forgot this, but isn't this a feature require but not a bug?

----------------------------------------
Bug #19362: #dup on Proc doesn't call initialize_dup
https://bugs.ruby-lang.org/issues/19362#change-105087

* Author: zverok (Victor Shepelev)
* Status: Open
* Priority: Normal
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
In #17545, `#dup` had changed to create an instance of the subclass.
It, though, doesn't invoke `initialize_dup` of the subclass, unlike other standard classes.

```ruby
class MyAry < Array
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

class MyString < String
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

class MyProc < Proc
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

MyString.new('test').dup   # prints MyString, "test"
MyAry.new(['test']).dup    # prints MyAry, ["test"]
MyProc.new { 'test' }.dup  # doesn't print anything
```
This makes the change in #17545 useless: while inheriting from core classes is indeed marginal, one of author's intention might be carrying additional information with the Proc instance, and bypassing `#initialize_dup` makes it impossible to maintain this information.

It seems that actually `#initialize_dup` is also invoked on the core classes themselves, but ignored on `Proc`. 
```ruby
class Array
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

class String
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

class Proc
  def initialize_dup(...)
    p(self.class, ...)
    super
  end
end

'test'.dup              # prints String, "test"
['test'].dup            # prints Array, ["test"]
Proc.new { 'test' }.dup # doesn't print anything
```

Which is an even more marginal problem but still an inconsistency.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/