From: "Eregon (Benoit Daloze) via ruby-core" Date: 2024-06-09T11:47:57+00:00 Subject: [ruby-core:118262] [Ruby master Feature#20309] Bundled gems for Ruby 3.5 Issue #20309 has been updated by Eregon (Benoit Daloze). I wonder if making `win32ole` a bundled gem is a good idea. >From what I have seen the consequence of such changes seems in most cases to encourage gems to drop the dependency on the newly-bundled gem. That may be good for e.g. ostruct which is kind of self-deprecated (due to horrible performance and messy semantics). But it may be bad for `win32ole`, because the alternatives may be slower or less reliable, e.g. see the discussion [here](https://github.com/ruby-concurrency/concurrent-ruby/pull/1053) where it's all too easy to regress from 60ms to 1s. I don't think many gems will consider adding `win32ole` as a dependency, because it looks very weird for usages of the gem on non-Windows. Even though the gem does seem to install OK on non-Windows, when installing CRuby on non-Windows, win32ole has never been installed as a default gem, so it looks unexpected to even install that gem. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-108760 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/