[#35027] [Ruby 1.9-Bug#4352][Open] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s) — "James M. Lawrence" <redmine@...>
Bug #4352: [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent w=
16 messages
2011/02/01
[#35041] [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— "James M. Lawrence" <redmine@...>
2011/02/02
Issue #4352 has been updated by James M. Lawrence.
[#35045] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Yusuke ENDOH <mame@...>
2011/02/02
Hi,
[#35046] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Rocky Bernstein <rockyb@...>
2011/02/02
On Wed, Feb 2, 2011 at 10:47 AM, Yusuke ENDOH <[email protected]> wrote:
[#35065] Re: [Ruby 1.9-Bug#4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
— Yusuke ENDOH <mame@...>
2011/02/03
Hi,
[#35036] [Ruby 1.9-Bug#4354][Open] File.realdirpath is expected to test for real file. — Luis Lavena <redmine@...>
Bug #4354: File.realdirpath is expected to test for real file.
3 messages
2011/02/02
[#35055] [Ruby 1.9-Bug#4359][Open] regular expressions created with Regexp::FIXEDENCODING have incorrect inspect — Aaron Patterson <redmine@...>
Bug #4359: regular expressions created with Regexp::FIXEDENCODING have incorrect inspect
4 messages
2011/02/02
[#35071] Bug in system()? — Anthony Wright <anthony@...>
I've just hit a problem where the system() method to call an external program failed in a fairly unpredictable way, and I couldn't get any clues from within ruby to diagnose the problem. As a result I ended up debugging process.c to work out what the problem was.
4 messages
2011/02/03
[#35100] [Ruby 1.9-Bug#4370][Open] Abort trap in net/http — David Phillips <redmine@...>
Bug #4370: Abort trap in net/http
4 messages
2011/02/05
[#35114] [Ruby 1.9-Bug#4373][Open] http.rb:677: [BUG] Segmentation fault — Christian Fazzini <redmine@...>
Bug #4373: http.rb:677: [BUG] Segmentation fault
59 messages
2011/02/06
[#35144] Documentation Clarifications to Array methods rotate, rotate!, index, and rindex — Loren Sands-Ramshaw <lorensr@...>
Tue Feb 8 11:47:11 2011 Loren Sands-Ramshaw <[email protected]>
3 messages
2011/02/08
[#35146] [Ruby 1.9-Bug#4383][Assigned] psych fails to parse a symbol in a flow sequence — Yuki Sonoda <redmine@...>
Bug #4383: psych fails to parse a symbol in a flow sequence
6 messages
2011/02/08
[#35167] Redmine misconfigured (was Re: Re: [Ruby 1.9-Bug#4340] Encoding of result string for String#gsub is not consistent) — mathew <meta@...>
On Tue, Feb 8, 2011 at 16:27, Eric Hodel <[email protected]> wrote:
3 messages
2011/02/09
[#35171] [Ruby 1.9-Bug#4386][Open] encoding: directive does not affect regex expressions — mathew murphy <redmine@...>
Bug #4386: encoding: directive does not affect regex expressions
9 messages
2011/02/09
[#35202] Patch to Net::InternetMessageIO — Daniel Cormier <daniel.cormier@...>
=A0=A0This patch addresses an issue when sending a message with Net::SMTP
7 messages
2011/02/11
[#35206] Re: Patch to Net::InternetMessageIO
— mathew <meta@...>
2011/02/11
On Fri, Feb 11, 2011 at 09:13, Daniel Cormier <[email protected]> wr=
[#35207] Re: Patch to Net::InternetMessageIO
— Daniel Cormier <daniel.cormier@...>
2011/02/11
Perhaps that is a better solution, but shouldn't sending a message
[#35233] Re: Patch to Net::InternetMessageIO
— mathew <meta@...>
2011/02/14
On Fri, Feb 11, 2011 at 17:08, Daniel Cormier <[email protected]> wrote:
[#35310] Re: Patch to Net::InternetMessageIO
— Daniel Cormier <daniel.cormier@...>
2011/02/19
Ok, but since the period escaping is already being done (just with
[#35237] [Ruby 1.9-Bug#4400][Open] nested at_exit hooks run in strange order — Suraj Kurapati <redmine@...>
Bug #4400: nested at_exit hooks run in strange order
12 messages
2011/02/15
[#35249] [Ruby 1.9-Bug#4400] nested at_exit hooks run in strange order
— Motohiro KOSAKI <redmine@...>
2011/02/15
Issue #4400 has been updated by Motohiro KOSAKI.
[#35332] [ANN] Planned maintenance of redmine.ruby-lang.org — "Yuki Sonoda (Yugui)" <yugui@...>
-----BEGIN PGP SIGNED MESSAGE-----
4 messages
2011/02/22
[#35352] Re: [ANN] Planned maintenance of redmine.ruby-lang.org
— "Yuki Sonoda (Yugui)" <yugui@...>
2011/02/23
-----BEGIN PGP SIGNED MESSAGE-----
[#35340] odd require behavior — Roger Pack <rogerdpack2@...>
Hello all.
5 messages
2011/02/22
[#35355] eval'ing large strings runs out of stack space? — Roger Pack <rogerdpack2@...>
Hello all.
7 messages
2011/02/23
[#35357] Re: eval'ing large strings runs out of stack space?
— "Martin J. Dst" <duerst@...>
2011/02/24
Hello Roger,
[#35356] suggestion: default irb to saving history — Roger Pack <rogerdpack2@...>
Hello all.
3 messages
2011/02/24
[#35367] [Ruby 1.9 - Bug #4440] [Open] odd evaluation order in a multiple assignment — Yusuke Endoh <mame@...>
5 messages
2011/02/24
[#35376] [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method — Suraj Kurapati <sunaku@...>
11 messages
2011/02/25
[#35378] Re: [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method
— "Martin J. Dürst" <duerst@...>
2011/02/25
string.force_encoding(ENCODING::BINARY).slice almost does what you want,
[#35379] Re: [Ruby 1.9 - Feature #4447] [Open] add String#byteslice() method
— Gary Wright <gwtmp01@...>
2011/02/25
[ruby-core:35139] [Ruby 1.9-Bug#4379][Open] [patch] eval(s, b, "(eval)", n) discards location
From:
"James M. Lawrence" <redmine@...>
Date:
2011-02-07 18:19:37 UTC
List:
ruby-core #35139
Bug #4379: [patch] eval(s, b, "(eval)", n) discards location
http://redmine.ruby-lang.org/issues/show/4379
Author: James M. Lawrence
Status: Open, Priority: Normal
Category: core, Target version: 1.9.x
ruby -v: ruby 1.9.3dev (2011-02-08 trunk 30820) [i386-darwin9.8.0]
% ruby -e 'p eval("raise", nil, "(eval)", 999)'
-e:1:in `eval': (eval):999:in `<main>': (RuntimeError)
from -e:1:in `eval'
from -e:1:in `<main>'
With binding, location is ignored.
% ruby -e 'p eval("raise", binding, "(eval)", 999)'
-e:1:in `<main>': unhandled exception
from -e:1:in `eval'
from -e:1:in `<main>'
source_location has a similar problem.
The patch also applies cleanly to 1.9.2.
----------------------------------------
http://redmine.ruby-lang.org
Attachments (2)
test_eval_location.patch
(762 Bytes, text/x-diff)
diff --git a/test/ruby/test_eval.rb b/test/ruby/test_eval.rb
index 299165f..50a58ad 100644
--- a/test/ruby/test_eval.rb
+++ b/test/ruby/test_eval.rb
@@ -430,4 +430,23 @@ class TestEval < Test::Unit::TestCase
result = foo.instance_eval(&foo_pr)
assert_equal(1, result, 'Bug #3786, Bug #3860, [ruby-core:32501]')
end
+
+ def test_eval_backtrace
+ begin
+ eval("raise", binding, "(eval)", 9999)
+ rescue => e
+ assert_match /:9999:/, e.backtrace[0]
+ end
+ end
+
+ def test_eval_source_location
+ expected = ["(eval)", 9999]
+
+ source =
+ "class << Object.new ;" <<
+ "def f ; end ;" <<
+ "instance_method(:f).source_location ; end"
+
+ assert_equal expected, eval(source, binding, *expected)
+ end
end
eval_location.patch
(1.26 KB, text/x-diff)
diff --git a/vm_eval.c b/vm_eval.c
index 0dcbafa..85d6e28 100644
--- a/vm_eval.c
+++ b/vm_eval.c
@@ -960,10 +960,13 @@ eval_string_with_cref(VALUE self, VALUE src, VALUE scope, NODE *cref, const char
rb_block_t block;
volatile int parse_in_eval;
volatile int mild_compile_error;
+ volatile int is_user_file = FALSE;
if (file == 0) {
file = rb_sourcefile();
line = rb_sourceline();
+ } else {
+ is_user_file = TRUE;
}
parse_in_eval = th->parse_in_eval;
@@ -977,7 +980,7 @@ eval_string_with_cref(VALUE self, VALUE src, VALUE scope, NODE *cref, const char
if (rb_obj_is_kind_of(scope, rb_cBinding)) {
GetBindingPtr(scope, bind);
envval = bind->env;
- if (strcmp(file, "(eval)") == 0 && bind->filename != Qnil) {
+ if (!is_user_file && strcmp(file, "(eval)") == 0 && bind->filename != Qnil) {
file = RSTRING_PTR(bind->filename);
line = bind->line_no;
}
@@ -1035,7 +1038,7 @@ eval_string_with_cref(VALUE self, VALUE src, VALUE scope, NODE *cref, const char
if (state) {
if (state == TAG_RAISE) {
VALUE errinfo = th->errinfo;
- if (strcmp(file, "(eval)") == 0) {
+ if (!is_user_file && strcmp(file, "(eval)") == 0) {
VALUE mesg, errat, bt2;
extern VALUE rb_get_backtrace(VALUE info);
ID id_mesg;