From: Vit Ondruch <v.ondruch@...>
Date: 2011-09-13T21:00:15+09:00
Subject: [ruby-core:39516] [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number


Issue #4576 has been updated by Vit Ondruch.


Michal Suchanek wrote:
> On 13 September 2011 12:28, Urabe Shyouhei <shyouhei@ruby-lang.org> wrote:
>  > (09/13/2011 06:56 PM), V��t Ondruch wrote:
>  >> Can somebody please reopen this issue? Since the test suite fix is
>  >> apparently wrong.
>  >
>  > Hi, maybe I'm too unfamiliar with this area, but can you explain a bit
>  > closer about how the test is apparently wrong? ��It seems OK to me.
>  
>  I see no error:
>  ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-linux]
>  
>  Thanks
>  
>  Michal


As I said, it is i386 or i686 issue, not x86_64.

----------------------------------------
Bug #4576: Range#step miss the last value, if end-exclusive and has float number
http://redmine.ruby-lang.org/issues/4576

Author: Joey Zhou
Status: Closed
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: -


=begin
Hi, I find that:

* if: range.exclude_end? == true
* and: any one in [begin_obj, end_obj, step] is a true Float(f.to_i != f)
* and: unless begin_obj + step*int == end_obj
* then: the result will miss the last value.

for example:

 p (1...6.3).step.to_a # => [1.0, 2.0, 3.0, 4.0, 5.0], no 6.0
 p (1.1...6).step.to_a # => [1.1, 2.1, 3.1, 4.1], no 5.1
 p (1...6).step(1.1).to_a # => [1.0, 2.1, 3.2, 4.300000000000001], no 5.4

 p (1.0...6.6).step(1.9).to_a # => [1.0, 2.9], no 4.8
 p (1.0...6.7).step(1.9).to_a # => [1.0, 2.9, 4.8]
 p (1.0...6.8).step(1.9).to_a # => [1.0, 2.9, 4.8], no 6.7

Maybe the #step is ok on integers, but there's something wrong if the range is end-exclusive and contain float numbers.
=end



-- 
http://redmine.ruby-lang.org