[#45426] [ruby-trunk - Feature #6546][Open] Net::HTTP to check for HTTP_PROXY environment setting. — "dekz (Jacob Evans)" <dekzter@...>

14 messages 2012/06/04

[#45431] [ruby-trunk - Bug #6548][Open] Rake doesn't ignore arguments after -- — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

12 messages 2012/06/05

[#45474] [ANN] Request for "slide-show" of your feature proposal — Yusuke Endoh <mame@...>

(Japanese later; 日本語が後にあります)

18 messages 2012/06/07

[#45563] [ruby-trunk - Bug #6573][Open] Webrick test failures — "bkabrda (Bohuslav Kabrda)" <bkabrda@...>

19 messages 2012/06/11

[#45567] [ruby-trunk - Bug #6575][Open] Thread#kill sets rb_errinfo() to Fixnum 8 after rb_protect(function, data, &error_tag) — ibc (Iñaki Baz Castillo) <ibc@...>

9 messages 2012/06/11

[#45647] [ruby-trunk - Bug #6592][Open] test_call_double(DL::TestDL) fails on ARM HardFP — "vo.x (Vit Ondruch)" <v.ondruch@...>

15 messages 2012/06/14

[#45657] [ruby-trunk - Feature #6594][Open] Integrated Functor — "trans (Thomas Sawyer)" <transfire@...>

20 messages 2012/06/15

[#45664] [ruby-trunk - Bug #6596][Open] New method for Arrays : Array#index — "robin850 (Robin Dupret)" <robin.dupret@...>

20 messages 2012/06/15

[#45694] [ruby-trunk - Feature #6602][Open] Tail call optimization: enable by default? — "ko1 (Koichi Sasada)" <redmine@...>

12 messages 2012/06/18

[#45715] [ruby-trunk - Feature #6609][Open] Toplevel as self extended module — "trans (Thomas Sawyer)" <transfire@...>

17 messages 2012/06/19

[#45732] [ruby-trunk - Bug #6614][Open] GC doesn't collect objects bound to (collectable) proc — "rogerdpack (Roger Pack)" <rogerpack2005@...>

9 messages 2012/06/20

[#45733] [ruby-trunk - Feature #6615][Open] Release GVL in zlib when calling inflate() or deflate() — "drbrain (Eric Hodel)" <[email protected]>

12 messages 2012/06/21

[#45735] [ruby-trunk - Bug #6616][Open] MinGW: cannot build extensions or run tests due changes in exec_arg? — "luislavena (Luis Lavena)" <luislavena@...>

9 messages 2012/06/21

[#45798] [ruby-trunk - Bug #6634][Open] Deadlock with join and ConditionVariable — "meh. (meh. I don't care)" <meh@...>

20 messages 2012/06/23

[#45805] [ruby-trunk - Feature #6636][Open] Enumerable#size — "marcandre (Marc-Andre Lafortune)" <ruby-core@...>

15 messages 2012/06/23

[#45864] [ruby-trunk - Bug #6647][Open] Exceptions raised in threads should be logged — "headius (Charles Nutter)" <headius@...>

71 messages 2012/06/25

[#45902] [ruby-trunk - Bug #6653][Open] 1.9.2/1.9.3 exhibit SEGV with many threads+tcp connections — "erikh (Erik Hollensbe)" <erik@...>

11 messages 2012/06/26

[#45960] [ruby-trunk - Feature #6669][Open] A method like Hash#map but returns hash — "yhara (Yutaka HARA)" <redmine@...>

18 messages 2012/06/29

[#45963] [ruby-trunk - Feature #6670][Open] str.chars.last should be possible — "yhara (Yutaka HARA)" <redmine@...>

36 messages 2012/06/29

[#46021] [ruby-trunk - Feature #6679][Open] Default Ruby source file encoding to utf-8 — "claytrump (Clay Trump)" <clay.trump@...>

21 messages 2012/06/30

[ruby-core:45682] [ruby-trunk - Bug #6601][Open] [readline]

From: "rctay (Tay Ray Chuan)" <rctay89@...>
Date: 2012-06-17 08:23:13 UTC
List: ruby-core #45682
Issue #6601 has been reported by rctay (Tay Ray Chuan).

----------------------------------------
Bug #6601: [readline] 
https://bugs.ruby-lang.org/issues/6601

Author: rctay (Tay Ray Chuan)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: ruby 1.9.3p236 (2012-06-11) [x86_64-linux]


=begin
= Steps to reproduce
Below are the steps to reproduce from an (({irb})) session. ^ is used to denote the cursor position on the screen.

* Type ((%puts :a%)) then ((%Enter%)). This is to populate the history for reverse-i-search.
 irb(main):001:0> puts :a
 a
 => nil

* Hit ((%Ctrl-R%)) (for reverse-i-search), followed by ((%u%)):
 (reverse-i-search)`u': puts :a
                         ^
* Hit ((%Alt-F%)) (for forward-word).

Observed: reverse-i-search terminated, with an 'f' inserted at cursor position.
 irb(main):002:0> pfuts :a
                    ^

Expected: reverse-i-search terminated, nothing inserted, cursor moves to end of the word (({puts})):
 irb(main):002:0> puts :a
                      ^

Note that other ((%Alt-*%)) commands don't work too (ie ((%x%)) is inserted instead of the command ((%Alt-x%)) being performed), including

* ((%Alt-B%)) (move backward a word)
* ((%Alt-C%)) (capitalize letter)
* ((%Alt-D%)) (delete till end of word)

= Fix

When we hit ((%Alt-F%)) from reverse-i-search, execution arrives at this piece of code in libreadline's (({isearch.c})):

 387       /* ESC still terminates the search, but if there is pending
 388          input or if input arrives within 0.1 seconds (on systems
 389          with select(2)) it is used as a prefix character
 390          with rl_execute_next.  WATCH OUT FOR THIS!  This is intended
 391          to allow the arrow keys to be used like ^F and ^B are used
 392          to terminate the search and execute the movement command.
 393          XXX - since _rl_input_available depends on the application-
 394          settable keyboard timeout value, this could alternatively
 395          use _rl_input_queued(100000) */
 396       if (cxt->lastc == ESC && _rl_input_available ())
 397         rl_execute_next (ESC);

Due to (({readline_getc()})), our (({rl_getc_function()})) implementation, (({IO::getbyte()})) is called, causing all input characters to be "swallowed" into our byte buffer in (({readline_instream})). Thus (({_rl_input_available()})) incorrectly returns false, and the keystrokes (eg. Alt, F) fail to be recognized as a binding for a command.

The proposed fix (attached) uses (({rb_io_read_pending()})) to emulate (({_rl_input_available()})), and calls (({rl_execute_next()})), as libreadline does.

= Affected Versions

Ruby trunk and 1.9.3 (latest) exhibits this issue.

Ruby 1.8 also has exhibits this issue, but the fix would be different since (({rl_getc_function()})) isn't overriden in (({ext/readline/readline.c})).

Tested on readline 6.2; blame'ing the above snippet shows that readline as far back as 5.1 should also give this behaviour.

=end


-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next