From: "marcandre (Marc-Andre Lafortune)" <ruby-core@...>
Date: 2012-11-17T01:48:01+09:00
Subject: [ruby-core:49444] [ruby-trunk - Bug #7369] Matrix #row_size, #column_size methods


Issue #7369 has been updated by marcandre (Marc-Andre Lafortune).

Category set to lib
Assignee set to marcandre (Marc-Andre Lafortune)

I agree that `{row|column}_size` can be ambiguous.

I don't believe `height/width` is used in this context though, at least in mathematics.

Possibilities I can think of: `column_count` or `nb_columns`.

Opinions?
----------------------------------------
Bug #7369: Matrix #row_size, #column_size methods
https://bugs.ruby-lang.org/issues/7369#change-32981

Author: boris_stitnicky (Boris Stitnicky)
Status: Open
Priority: Normal
Assignee: marcandre (Marc-Andre Lafortune)
Category: lib
Target version: 
ruby -v: 1.9.x


I believe these methods should be renamed. "row_size" is confusing, because it can be intuitively understood as both "number of rows", and "size along a row" (or size of a matrix row). Same goes for "column size". I would like these methods renamed to unambigous, mnemonic names, such as

#number_of_rows alias #height
#number_of_columns alias #width

I do not insist on the above names. They are just examples of unambigous, mnemonic names. But I insist that "row_size" and "column_size" method names impress me as ambiguous.


-- 
http://bugs.ruby-lang.org/