From: "phasis68 (Heesob Park)" <phasis@...>
Date: 2013-01-23T15:16:16+09:00
Subject: [ruby-core:51579] [Backport93 - Backport #7721] test_too_long_path2(TestProcess) fails on mingw32


Issue #7721 has been updated by phasis68 (Heesob Park).


This bug is not solved with changeset r38904.

There are some warnings.

compiling win32/win32.c
win32/win32.c: In function 'rb_w32_aspawn_flags':
win32/win32.c:1296:14: warning: 'ret' may be used uninitialized in this function

win32/win32.c: In function 'rb_w32_spawn':
win32/win32.c:1187:14: warning: 'ret' may be used uninitialized in this function

win32/win32.c: In function 'rb_w32_aspawn_flags.clone.8':
win32/win32.c:1296:14: warning: 'ret' may be used uninitialized in this function


And the test still fails.

 19) Failure:
test_too_long_path2(TestProcess) [C:/work/snapshot-mg32/test/ruby/test_process.rb:1393]:
[ruby-core:34833].
[Errno::ENOENT, Errno::E2BIG] expected but nothing was raised.

Here is a patch:
diff --git a/win32.c b/win32.c.new
index 8b577ea..984e03b 100644
--- a/win32.c
+++ b/win32.c.new
@@ -1184,7 +1184,7 @@ rb_w32_spawn(int mode, const char *cmd, const char *prog)
     const char *shell = NULL;
     WCHAR *wcmd = NULL, *wshell = NULL;
     int e = 0;
-    rb_pid_t ret;
+    rb_pid_t ret = -1;
     VALUE v = 0;
     VALUE v2 = 0;
 
@@ -1293,7 +1293,7 @@ rb_w32_aspawn_flags(int mode, const char *prog, char *const *argv, DWORD flags)
     char *cmd, fbuf[MAXPATHLEN];
     WCHAR *wcmd = NULL, *wprog = NULL;
     int e = 0;
-    rb_pid_t ret;
+    rb_pid_t ret = -1;
     VALUE v = 0;
 
     if (check_spawn_mode(mode)) return -1;

----------------------------------------
Backport #7721: test_too_long_path2(TestProcess) fails on mingw32
https://bugs.ruby-lang.org/issues/7721#change-35539

Author: phasis68 (Heesob Park)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: 
Target version: 


[ 6319/11317] TestProcess#test_too_long_path2Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.

C:\work\snapshot-mg32>exit
 = 8.03 s
 33) Failure:
test_too_long_path2(TestProcess) [C:/work/snapshot-mg32/test/ruby/test_process.rb:1393]:
[ruby-core:34833].
[Errno::ENOENT, Errno::E2BIG] expected but nothing was raised.

This failure is also mentioned at https://bugs.ruby-lang.org/issues/7710#note-3



-- 
http://bugs.ruby-lang.org/