From: ngotogenome@...
Date: 2014-07-18T16:33:58+00:00
Subject: [ruby-core:63829] [ruby-trunk - Feature #10058] [PATCH] Fix some	coding styles

Issue #10058 has been updated by Naohisa Goto.


> Naohisa Goto: Good point about __send__, I imagine it is to avoid classes that redefined send? In any case, I revised the uses of send in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.

Yes, using send is fine when calling Matrix classes' methods which are under your maintenance. When calling other classes which may not have the original behavior of send method, using "__send__" is better.

----------------------------------------
Feature #10058: [PATCH] Fix some coding styles
https://bugs.ruby-lang.org/issues/10058#change-47863

* Author: gogo tanaka
* Status: Open
* Priority: Low
* Assignee: Marc-Andre Lafortune
* Category: 
* Target version: 
----------------------------------------
When I read codes, I notice some issues about coding style.

If you don't mind that, you can ignore my patches. It's just coding style problem.

������������������������������������������������������������������������������������������������������������PATCH���������������������

������������redmine, ruby���������������������������������������������������������������������������������������������������

���������������������������������������������������������. 

���������������������������������������������������������������������������������������������. 

* There are both `&&` and `and`. So, I Unify with `&&` 

* There are both `send :xxx` and `send(:xxx)`  expressions. So, I Unify with `send(:xxx)` 

*  I reorder methods. I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)

---Files--------------------------------
unify_product_operator.patch (879 Bytes)
reorder_Matrix#real_and_Matrix_imaginary.patch (1.3 KB)
use_method_with_parenthesis.patch (1021 Bytes)


-- 
https://bugs.ruby-lang.org/