From: shugo@...
Date: 2015-10-21T02:57:24+00:00
Subject: [ruby-core:71128] [Ruby trunk - Feature #8976] [Assigned] file-scope freeze_string directive

Issue #8976 has been updated by Shugo Maeda.

Status changed from Open to Assigned
Assignee changed from Nobuyoshi Nakada to Yukihiro Matsumoto

Benoit Daloze wrote:
> Yusuke Endoh wrote:
> > Does nobu seriously require all Rubyists to write codes like this?  ;-)
> > 
> > https://github.com/ruby/ruby/commit/36ca18b84715dcc92a82ec4cbef6e83321640443
> > 
> > Leave emacs aside, I still believe this magic comment must not require `-*-`.  It is too error-prone.
> 
> Agreed, to me this is a fatal flaw of the current implementation of parsing the magic comment and it is very inconsistent.

+1

This issue should be discussed at the developers meeting today, and Matz should desicde whether `-*-` should be required.

----------------------------------------
Feature #8976: file-scope freeze_string directive
https://bugs.ruby-lang.org/issues/8976#change-54499

* Author: Akira Tanaka
* Status: Assigned
* Priority: Normal
* Assignee: Yukihiro Matsumoto
----------------------------------------
Yesterday, we had a face-to-face developer meeting.
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20131001Japan
Several committers attended.
matz didn't attended, though.  (This means this issue is not concluded.)

We believe we found a better way to freeze static string literals for
less GC pressure.
"static string literal" is a string literal without dynamic expression.

Currently, `f`-suffix, `"..."f`, is used to freeze a string literal to avoid
String object allocation.

There are several problems for `f`-suffix:

* The notation is ugly.
* Syntax error on Ruby 2.0.
  We cannot use the feature in version independent libraries.
  So, it is difficult to deploy.
* Need to modify for each string literal.
  This is cumbersome.

The new way we found is a file-scope directive as follows

  # freeze_string: true

The above comment at top of a file changes semantics of
static string literals in the file.
The static string literals will be frozen and always returns same object.
(The semantics of dynamic string literals is not changed.)

This way has following benefits:

* No ugly `f`-suffix.
* No syntax error on older Ruby.
* We need only a line for each file.

We can write version independent library using frozen static string literals as follows.

* Use the directive at top of the file: `# freeze_string: true`
  Older Ruby ignore this as a comment.
* Use `"...".dup` for strings to be modified.
  Older Ruby has small disadvantage: useless `dup` is called.

Note that the directive effects all static string literals regardless of
single quotes, double quotes, `%q`-string, `%qq`-string and here documents.
The reason that the directive is effective not only single quotes is
we want to use escape sequences such as `\n` in frozen string literals.

Also note that similar directive is already exist:

~~~
% ruby -w -e '
def m
  end
'
-e:3: warning: mismatched indentations at 'end' with 'def' at 2
% ruby -w -e '# -*- warn_indent: false -*-
def m
  end
'
~~~

The directive, `warn_indent: false`, disables "mismatched indentations" warning.

nobu implemented this feature in the meeting.
Please attach the patch, nobu.




-- 
https://bugs.ruby-lang.org/