From: naruse@... Date: 2016-07-19T08:16:50+00:00 Subject: [ruby-core:76426] [Ruby trunk Feature#12386][Assigned] Move definition of ONIG_CASE_MAPPING compilation switch outside onigumo files Issue #12386 has been updated by Yui NARUSE. Status changed from Open to Assigned Assignee changed from Nobuyoshi Nakada to Martin D��rst The upstream of Ruby's regexp is [Onigmo's ruby branch](https://github.com/k-takata/Onigmo/tree/ruby-2.x). It is much different from master. Therefore an extra ifdef, ONIG_CASE_MAPPING, is not needed. Just write without ifdefs. ---------------------------------------- Feature #12386: Move definition of ONIG_CASE_MAPPING compilation switch outside onigumo files https://bugs.ruby-lang.org/issues/12386#change-59669 * Author: Martin D��rst * Status: Assigned * Priority: Normal * Assignee: Martin D��rst ---------------------------------------- At r55018, in include/ruby/oniguruma.h, at line 131, I introduced the compilation switch ONIG_CASE_MAPPING. The purpose of this switch is to isolate the case-mapping functionality that is introduced into Ruby but is not used with regular expressions. The definition on line 131 should be moved outside oniguruma.h, to a location that makes sure it is seen in oniguruma.h and all files that include it, but will not be part of backwards pull requests to onigumo. Such a location may either be an option setting in some make file or a suitable .h file included into oniguruma.h. I trust Nobu to find the best location for this. -- https://bugs.ruby-lang.org/ Unsubscribe: