From: jaruga@... Date: 2018-09-14T13:48:36+00:00 Subject: [ruby-core:89012] [Ruby trunk Bug#15116] Fixing issues detected by an Analysis tool. Issue #15116 has been updated by jaruga (Jun Aruga). To be clear, those 9 issues about mainly leaked resource in the attached report file are marked as "important" by the analysis too for ruby 2.5.1 + some patch files. Total 9 * 1 COPY_PASTE_ERROR * 7 RESOURCE_LEAK * 1 USE_AFTER_FREE However as a "not important" issues, around 1000 issues were detected by the tool for the ruby 2.5.1. I am considering how to deal with this or report those. I might open an another ticket for that. ---------------------------------------- Bug #15116: Fixing issues detected by an Analysis tool. https://bugs.ruby-lang.org/issues/15116#change-74040 * Author: jaruga (Jun Aruga) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- When running a code analysis tool including several sub tools (mainly Coverty [1]), some issues were detected by it. You can refer attached issues_report.txt for detail. Some issues in the issues_report.txt might be false positive. (Those might be wrongly detected.) I tried to fix those by below 2 pull-requests. https://github.com/ruby/ruby/pull/1956 https://github.com/ruby/net-telnet/pull/15 The summary is * Fix leaked storage in addr2line.c. * Fix passing freed pointer as an argument in gc.c. * Fix leaked handle variable "n" in process.c. * Fix for "top_root" leaking the resource. After above patches, the issues were not detected. But I need your help to check if my code is valid. Thank you. [1] https://scan.coverity.com/ ---Files-------------------------------- issues_report.txt (7.74 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: