Debian Bug report logs - #1093160
rsync: failed verification -- update discarded

version graph

Package: rsync; Maintainer for rsync is Samuel Henrique <[email protected]>; Source for rsync is src:rsync (PTS, buildd, popcon).

Affects: release.debian.org, security.debian.org

Reported by: Vincent Lefevre <[email protected]>

Date: Wed, 15 Jan 2025 22:33:01 UTC

Severity: important

Tags: confirmed, upstream

Merged with 1106088

Found in versions rsync/3.2.7-1+deb12u2, rsync/3.2.7-1+deb12u1, rsync/3.3.0+ds1-3, rsync/3.4.1+ds1-3, rsync/3.3.0+ds1-4

Forwarded to https://github.com/RsyncProject/rsync/issues/715

Reply or subscribe to this bug.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Wed, 15 Jan 2025 22:33:01 GMT) (full text, mbox, link).


Acknowledgement sent to Vincent Lefevre <[email protected]>:
New Bug report received and forwarded. Copy sent to Paul Slootman <[email protected]>. (Wed, 15 Jan 2025 22:33:01 GMT) (full text, mbox, link).


Message #5 received at [email protected] (full text, mbox, reply):

From: Vincent Lefevre <[email protected]>
To: Debian Bug Tracking System <[email protected]>
Subject: rsync: failed verification -- update discarded
Date: Wed, 15 Jan 2025 23:30:22 +0100
Package: rsync
Version: 3.3.0+ds1-2
Severity: grave
Justification: renders package unusable

When updated a directory with "rsync -KRlptzv --progress",
I now get errors like

ERROR: public_html/cine/index.fr.html failed verification -- update discarded.
ERROR: public_html/cine/perso-lyon.txt failed verification -- update discarded.
ERROR: public_html/cine/watch.fr.html failed verification -- update discarded.
[...]
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.7.12-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages rsync depends on:
ii  init-system-helpers  1.68
ii  libacl1              2.3.2-2+b1
ii  libc6                2.40-5
ii  liblz4-1             1.9.4-4
ii  libpopt0             1.19+dfsg-2
ii  libssl3t64           3.4.0-2
ii  libxxhash0           0.8.3-2
ii  libzstd1             1.5.6+dfsg-2
ii  zlib1g               1:1.3.dfsg+really1.3.1-1+b1

rsync recommends no packages.

Versions of packages rsync suggests:
ii  openssh-client       1:9.9p1-3
ii  openssh-server       1:9.9p1-3
ii  python3              3.12.8-1
pn  python3-braceexpand  <none>

-- no debconf information

-- 
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Wed, 15 Jan 2025 22:39:01 GMT) (full text, mbox, link).


Acknowledgement sent to Vincent Lefevre <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Wed, 15 Jan 2025 22:39:01 GMT) (full text, mbox, link).


Message #10 received at [email protected] (full text, mbox, reply):

From: Vincent Lefevre <[email protected]>
To: [email protected]
Subject: Re: rsync: failed verification -- update discarded
Date: Wed, 15 Jan 2025 23:38:12 +0100
On 2025-01-15 23:30:22 +0100, Vincent Lefevre wrote:
> When updated a directory with "rsync -KRlptzv --progress",
> I now get errors like
> 
> ERROR: public_html/cine/index.fr.html failed verification -- update discarded.
> ERROR: public_html/cine/perso-lyon.txt failed verification -- update discarded.
> ERROR: public_html/cine/watch.fr.html failed verification -- update discarded.
> [...]
> rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]

This actually occurs with a remote host having rsync 3.2.7-1+deb12u1
(bookworm-security). Downgrading to rsync 3.2.7-1 there solves the
problem.

-- 
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Thu, 16 Jan 2025 05:00:01 GMT) (full text, mbox, link).


Acknowledgement sent to Salvatore Bonaccorso <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Thu, 16 Jan 2025 05:00:01 GMT) (full text, mbox, link).


Message #15 received at [email protected] (full text, mbox, reply):

From: Salvatore Bonaccorso <[email protected]>
To: Vincent Lefevre <[email protected]>, [email protected]
Subject: Re: Bug#1093160: rsync: failed verification -- update discarded
Date: Thu, 16 Jan 2025 05:57:27 +0100
Control: tags -1 + moreinfo

Hi Vincent,

On Wed, Jan 15, 2025 at 11:38:12PM +0100, Vincent Lefevre wrote:
> On 2025-01-15 23:30:22 +0100, Vincent Lefevre wrote:
> > When updated a directory with "rsync -KRlptzv --progress",
> > I now get errors like
> > 
> > ERROR: public_html/cine/index.fr.html failed verification -- update discarded.
> > ERROR: public_html/cine/perso-lyon.txt failed verification -- update discarded.
> > ERROR: public_html/cine/watch.fr.html failed verification -- update discarded.
> > [...]
> > rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]
> 
> This actually occurs with a remote host having rsync 3.2.7-1+deb12u1
> (bookworm-security). Downgrading to rsync 3.2.7-1 there solves the
> problem.

Have you more information on the setup which triggers this? Do you
have a minimal reproducing case to show the problem? 

(I might have overseen it but are you using the rsyncd on the remote
side or using a remote ssh shell for the transport? Can you paste full
command as well, if needed anonyized).

Regards,
Salvatore



Added tag(s) moreinfo. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 05:00:01 GMT) (full text, mbox, link).


Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Thu, 16 Jan 2025 09:33:01 GMT) (full text, mbox, link).


Acknowledgement sent to Vincent Lefevre <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Thu, 16 Jan 2025 09:33:01 GMT) (full text, mbox, link).


Message #22 received at [email protected] (full text, mbox, reply):

From: Vincent Lefevre <[email protected]>
To: Salvatore Bonaccorso <[email protected]>
Cc: [email protected]
Subject: Re: Bug#1093160: rsync: failed verification -- update discarded
Date: Thu, 16 Jan 2025 10:30:21 +0100
Hi Salvatore,

On 2025-01-16 05:57:27 +0100, Salvatore Bonaccorso wrote:
> Have you more information on the setup which triggers this? Do you
> have a minimal reproducing case to show the problem? 

This seems to be due to the -K option.

On the Debian bookworm machine (joooj):

$ mkdir real-dir
$ ln -s real-dir dir

On the Debian/unstable machine:

$ mkdir dir
$ echo foo > dir/file

A first rsync from this machine succeeds:

$ rsync -KRlptzv dir/file joooj:
Connected to joooj (from 2a02:8428:1b1d:4d01:96a9:491d:7b48:ba31)
OS: Debian GNU/Linux 12 (bookworm) [x86_64]
dir/
dir/file

sent 121 bytes  received 38 bytes  106.00 bytes/sec
total size is 4  speedup is 0.03

But a second one (with the file already created on joooj) fails:

$ touch dir/file
$ rsync -KRlptzv dir/file joooj:
Connected to joooj (from 2a02:8428:1b1d:4d01:96a9:491d:7b48:ba31)
OS: Debian GNU/Linux 12 (bookworm) [x86_64]
dir/
dir/file
WARNING: dir/file failed verification -- update discarded (will try again).
dir/file
ERROR: dir/file failed verification -- update discarded.

sent 147 bytes  received 89 bytes  157.33 bytes/sec
total size is 4  speedup is 0.02
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]

> (I might have overseen it but are you using the rsyncd on the remote
> side or using a remote ssh shell for the transport? Can you paste full
> command as well, if needed anonyized).

No rsyncd. BTW, I have an environment variable

  RSYNC_RSH=/home/vinc17/scripts/ssh

But I can reproduce the failure with just

  RSYNC_RSH=ssh

-- 
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Thu, 16 Jan 2025 09:42:02 GMT) (full text, mbox, link).


Acknowledgement sent to Vincent Lefevre <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Thu, 16 Jan 2025 09:42:02 GMT) (full text, mbox, link).


Message #27 received at [email protected] (full text, mbox, reply):

From: Vincent Lefevre <[email protected]>
To: Salvatore Bonaccorso <[email protected]>
Cc: [email protected]
Subject: Re: Bug#1093160: rsync: failed verification -- update discarded
Date: Thu, 16 Jan 2025 10:38:57 +0100
Control: found -1 3.2.7-1+deb12u1
Control: notfound -1 rsync/3.3.0+ds1-2

On 2025-01-16 10:30:21 +0100, Vincent Lefevre wrote:
> This seems to be due to the -K option.
> 
> On the Debian bookworm machine (joooj):
[...]

The same failure can be reproduced on this machine only: just create
the source dir/file on some other subdirectory, e.g. under /tmp.

joooj:/tmp> mkdir dir
joooj:/tmp> echo foo > dir/file
joooj:/tmp> rsync -KRlptzv dir/file localhost:
Connected to joooj (from ::1)
OS: Debian GNU/Linux 12 (bookworm) [x86_64]
dir/
dir/file
WARNING: dir/file failed verification -- update discarded (will try again).
dir/file
ERROR: dir/file failed verification -- update discarded.

sent 147 bytes  received 89 bytes  157.33 bytes/sec
total size is 4  speedup is 0.02
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.2.7]

where the home directory still has the dir -> real-dir symlink
and an existing real-dir/file file.

So the issue comes from the rsync 3.2.7-1+deb12u1 package only.

-- 
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



Marked as found in versions rsync/3.2.7-1+deb12u1. Request was from Vincent Lefevre <[email protected]> to [email protected]. (Thu, 16 Jan 2025 09:42:02 GMT) (full text, mbox, link).


No longer marked as found in versions rsync/3.3.0+ds1-2. Request was from Vincent Lefevre <[email protected]> to [email protected]. (Thu, 16 Jan 2025 09:42:02 GMT) (full text, mbox, link).


Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Thu, 16 Jan 2025 10:54:04 GMT) (full text, mbox, link).


Acknowledgement sent to Salvatore Bonaccorso <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Thu, 16 Jan 2025 10:54:04 GMT) (full text, mbox, link).


Message #36 received at [email protected] (full text, mbox, reply):

From: Salvatore Bonaccorso <[email protected]>
To: Vincent Lefevre <[email protected]>, [email protected]
Subject: Re: Bug#1093160: rsync: failed verification -- update discarded
Date: Thu, 16 Jan 2025 11:51:03 +0100
Control: tags -1 + confirmed

Hi Vincent,

On Thu, Jan 16, 2025 at 10:38:57AM +0100, Vincent Lefevre wrote:
> Control: found -1 3.2.7-1+deb12u1
> Control: notfound -1 rsync/3.3.0+ds1-2
> 
> On 2025-01-16 10:30:21 +0100, Vincent Lefevre wrote:
> > This seems to be due to the -K option.
> > 
> > On the Debian bookworm machine (joooj):
> [...]
> 
> The same failure can be reproduced on this machine only: just create
> the source dir/file on some other subdirectory, e.g. under /tmp.
> 
> joooj:/tmp> mkdir dir
> joooj:/tmp> echo foo > dir/file
> joooj:/tmp> rsync -KRlptzv dir/file localhost:
> Connected to joooj (from ::1)
> OS: Debian GNU/Linux 12 (bookworm) [x86_64]
> dir/
> dir/file
> WARNING: dir/file failed verification -- update discarded (will try again).
> dir/file
> ERROR: dir/file failed verification -- update discarded.
> 
> sent 147 bytes  received 89 bytes  157.33 bytes/sec
> total size is 4  speedup is 0.02
> rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.2.7]
> 
> where the home directory still has the dir -> real-dir symlink
> and an existing real-dir/file file.
> 
> So the issue comes from the rsync 3.2.7-1+deb12u1 package only.

Thanks for the reproducing steps, I can confirm it fails with both the
current 3.2.7-1+deb12u1 and with the changes for the other regression
as they are in 3.2.7-1+deb12u2.

Regards,
Salvatore



Added tag(s) confirmed. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 10:54:04 GMT) (full text, mbox, link).


Set Bug forwarded-to-address to 'https://github.com/RsyncProject/rsync/issues/715'. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 11:51:02 GMT) (full text, mbox, link).


Information forwarded to [email protected], Paul Slootman <[email protected]>:
Bug#1093160; Package rsync. (Thu, 16 Jan 2025 12:09:02 GMT) (full text, mbox, link).


Acknowledgement sent to Salvatore Bonaccorso <[email protected]>:
Extra info received and forwarded to list. Copy sent to Paul Slootman <[email protected]>. (Thu, 16 Jan 2025 12:09:02 GMT) (full text, mbox, link).


Message #45 received at [email protected] (full text, mbox, reply):

From: Salvatore Bonaccorso <[email protected]>
To: Vincent Lefevre <[email protected]>
Cc: [email protected]
Subject: Re: Bug#1093160: rsync: failed verification -- update discarded
Date: Thu, 16 Jan 2025 13:05:42 +0100
Control: found -1 3.3.0+ds1-4

Hi,

On Thu, Jan 16, 2025 at 11:51:03AM +0100, Salvatore Bonaccorso wrote:
> Control: tags -1 + confirmed
> 
> Hi Vincent,
> 
> On Thu, Jan 16, 2025 at 10:38:57AM +0100, Vincent Lefevre wrote:
> > Control: found -1 3.2.7-1+deb12u1
> > Control: notfound -1 rsync/3.3.0+ds1-2
> > 
> > On 2025-01-16 10:30:21 +0100, Vincent Lefevre wrote:
> > > This seems to be due to the -K option.
> > > 
> > > On the Debian bookworm machine (joooj):
> > [...]
> > 
> > The same failure can be reproduced on this machine only: just create
> > the source dir/file on some other subdirectory, e.g. under /tmp.
> > 
> > joooj:/tmp> mkdir dir
> > joooj:/tmp> echo foo > dir/file
> > joooj:/tmp> rsync -KRlptzv dir/file localhost:
> > Connected to joooj (from ::1)
> > OS: Debian GNU/Linux 12 (bookworm) [x86_64]
> > dir/
> > dir/file
> > WARNING: dir/file failed verification -- update discarded (will try again).
> > dir/file
> > ERROR: dir/file failed verification -- update discarded.
> > 
> > sent 147 bytes  received 89 bytes  157.33 bytes/sec
> > total size is 4  speedup is 0.02
> > rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.2.7]
> > 
> > where the home directory still has the dir -> real-dir symlink
> > and an existing real-dir/file file.
> > 
> > So the issue comes from the rsync 3.2.7-1+deb12u1 package only.
> 
> Thanks for the reproducing steps, I can confirm it fails with both the
> current 3.2.7-1+deb12u1 and with the changes for the other regression
> as they are in 3.2.7-1+deb12u2.

And with the steps from 

https://github.com/RsyncProject/rsync/issues/715

I can as well reproduce the issue with the current unstable version.

Regards,
Salvatore



Marked as found in versions rsync/3.3.0+ds1-4. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 12:09:02 GMT) (full text, mbox, link).


Added tag(s) upstream. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 12:57:02 GMT) (full text, mbox, link).


Removed tag(s) moreinfo. Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 12:57:02 GMT) (full text, mbox, link).


Added indication that 1093160 affects security.debian.org and release.debian.org Request was from Salvatore Bonaccorso <[email protected]> to [email protected]. (Thu, 16 Jan 2025 16:51:01 GMT) (full text, mbox, link).


Information forwarded to [email protected], Samuel Henrique <[email protected]>:
Bug#1093160; Package rsync. (Sun, 27 Apr 2025 14:24:01 GMT) (full text, mbox, link).


Acknowledgement sent to Ben Hutchings <[email protected]>:
Extra info received and forwarded to list. Copy sent to Samuel Henrique <[email protected]>. (Sun, 27 Apr 2025 14:24:01 GMT) (full text, mbox, link).


Message #58 received at [email protected] (full text, mbox, reply):

From: Ben Hutchings <[email protected]>
To: [email protected]
Subject: Re: rsync: failed verification -- update discarded
Date: Sun, 27 Apr 2025 16:20:57 +0200
[Message part 1 (text/plain, inline)]
Control: severity -1 important

While this is an unfortunate regression, it does not 'render the package
unusable' in general.

Ben.

-- 
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
[signature.asc (application/pgp-signature, inline)]

Severity set to 'important' from 'grave' Request was from Ben Hutchings <[email protected]> to [email protected]. (Sun, 27 Apr 2025 14:24:01 GMT) (full text, mbox, link).


Marked as found in versions rsync/3.2.7-1+deb12u2, rsync/3.3.0+ds1-3, and rsync/3.4.1+ds1-3. Request was from Samuel Henrique <[email protected]> to [email protected]. (Thu, 22 May 2025 23:03:01 GMT) (full text, mbox, link).


Merged 1093160 1106088 Request was from Samuel Henrique <[email protected]> to [email protected]. (Thu, 22 May 2025 23:03:04 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Sun Aug 3 05:30:50 2025; Machine Name: berlioz

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.