[Documentation] Update doc on creating mach commands
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox139 fixed)
Tracking | Status | |
---|---|---|
firefox139 | --- | fixed |
People
(Reporter: adhaliwal34, Assigned: adhaliwal34)
Details
Attachments
(2 files, 1 obsolete file)
Steps to reproduce:
The current document is not up-to-date regarding the category, description, and MACH_COMMANDS requirements of creating a new mach command.
Actual results:
Following the doc leads to errors
Expected results:
Update the doc with the newer category, description, and MACH_COMMANDS requirements. Please see attached file.
Assignee | ||
Comment 1•1 year ago
|
||
I have also updated the code in the Conditionally Filtering Commands
section.
The Minimizing Code in Commands
section probably needs to be rewritten because using the new MACH_COMMANDS dictionary, I assume, not all mach commands are loaded every time mach is called. Probably best left to another bug report.
Comment 2•1 year ago
|
||
We don't use bugzilla for code review. please submit your changes on https://phabricator.services.mozilla.com/
See:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Assignee | ||
Comment 3•1 year ago
|
||
Update the doc with the newer category, description, and MACH_COMMANDS requirements.
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
Remove reference to Mozilla source directory.
Emphasise alphabetical order of MACH_COMMANDS
dictionary.
Updated•7 months ago
|
Comment 5•2 months ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:adhaliwal34, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Comment 6•2 months ago
|
||
I will commandeer this and get it landed.
Updated•2 months ago
|
Comment 8•1 month ago
|
||
bugherder |
Description
•