Google Git
Sign in
chromium / chromium / src / 0d71c47ae6d383587cdbbef1bf8c50f6b6e3016b
commit0d71c47ae6d383587cdbbef1bf8c50f6b6e3016b[log] [tgz]
authorBen Chin <[email protected]>Thu Oct 09 01:28:52 2025
committerChromium LUCI CQ <[email protected]>Thu Oct 09 01:28:52 2025
tree8df73c8d2ccf967d8427ffb0820de0817c43f292
parente488f6054441dcbba93fd502519ac1b812d585cc [diff]
Dismiss extension popup on window resize

This change implements two improvements to the extension popup menu:

1. The popup now automatically dismisses when the application window is
resized. This is achieved by enabling `setDismissOnScreenSizeChange` on
the `AnchoredPopupWindow`, which utilizes a `WindowBoundsChangeDetector`
to listen for layout changes and close the popup accordingly. This
ensures the popup's position remains valid and improves user experience.

2. The extensions menu button now properly toggles the menu's
visibility. Previously, clicking the button while the menu was open
would cause it to quickly close and reopen. Now, it cleanly dismisses
the menu if it is already visible.

Bug: 443868365
Change-Id: Iaa2b8669dac369943bce073b21f27ad74b9e4821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7015867
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Ben Chin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1527277}
3 files changed
tree: 8df73c8d2ccf967d8427ffb0820de0817c43f292
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.