| commit | 6da09f7510e94d2aebbbed13b038d71c511d6cbc | [log] [tgz] |
|---|---|---|
| author | Marko Ivanovich <[email protected]> | Tue Oct 06 06:42:55 2020 |
| committer | Commit Bot <[email protected]> | Tue Oct 06 06:42:55 2020 |
| tree | 489c601eccae65a43efedb29bf805f6f84b2d5c7 | |
| parent | 9e8bb21767286faf1a951effecd38cd8e18fda2c [diff] |
Wait for correct event in test The test ChildFrameCrashMetrics_ScrolledIntoView might fail if we wait for WidgetHostMsg_WaitForNextFrameForTests_ACK, because it is sent from compositor thread, almost independently from FrameHostMsg_UpdateViewportIntersection, which is sent from main thread. Problem can be reproduced deterministically if we put sleep in RenderFrameProxy::UpdateRemoteViewportIntersection, to simulate preemption by OS scheduler. What we really want to wait for in this test is viewport intersection update in UI thread. Only after that we can check histograms. If we wait for lifecycle update, that will guarantee that all IPCs are processed in browser, including FrameHostMsg_UpdateViewportIntersection. Change-Id: I1ff2e6632b2f1391a3dee82b2bc6667bb20bf71d Bug: 1115096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307373 Reviewed-by: danakj <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Stefan Zager <[email protected]> Commit-Queue: Charlie Reis <[email protected]> Cr-Commit-Position: refs/heads/master@{#814114}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.