Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 10452027: Explicitly check reporting state when returning the entropy source. (Closed)

Created:
8 years, 7 months ago by SteveT
Modified:
8 years, 7 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Explicitly check reporting state when returning the entropy source. We used to CHECK if the client ID was set but we were not reporting metrics, but this is not technically guaranteed since the user can enable or disable UMA without changing the locally stored client ID. BUG=none TEST=Ensure that enabling and disabling UMA in an official build does not crash Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138999

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/metrics/metrics_service.cc View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
SteveT
This should do it. Let me know if you don't like ternary statements :) Steve
8 years, 7 months ago (2012-05-25 01:48:24 UTC) #1
jar (doing other things)
drive by..... https://chromiumcodereview.appspot.com/10452027/diff/1/chrome/browser/metrics/metrics_service.cc File chrome/browser/metrics/metrics_service.cc (right): https://chromiumcodereview.appspot.com/10452027/diff/1/chrome/browser/metrics/metrics_service.cc#newcode476 chrome/browser/metrics/metrics_service.cc:476: low_entropy_source; nit: re: ternary (which you mentioned): ...
8 years, 7 months ago (2012-05-25 02:10:26 UTC) #2
Ilya Sherman
LGTM with Jim's nit addressed.
8 years, 7 months ago (2012-05-25 02:49:38 UTC) #3
Ilya Sherman
Actually, one more nit: https://chromiumcodereview.appspot.com/10452027/diff/1/chrome/browser/metrics/metrics_service.cc File chrome/browser/metrics/metrics_service.cc (right): https://chromiumcodereview.appspot.com/10452027/diff/1/chrome/browser/metrics/metrics_service.cc#newcode468 chrome/browser/metrics/metrics_service.cc:468: // Note that client_id_ is ...
8 years, 7 months ago (2012-05-25 02:50:09 UTC) #4
SteveT
This was a lesson I should have learned from a past Jim-review :) Okay! Will ...
8 years, 7 months ago (2012-05-25 04:37:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10452027/6002
8 years, 7 months ago (2012-05-25 04:37:27 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 05:45:44 UTC) #7
Change committed as 138999

Powered by Google App Engine
This is Rietveld 408576698