Move StatisticsRecorder out of histogram.cc/h for further refactoring.

Move StatisticsRecorder out of histogram.cc/h for further refactoring.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146659

[jar (doing other things), 2012-07-02 23:59:15]

nit... and then LGTM

Be sure to use try bots before landing!!!

http://codereview.chromium.org/10703037/diff/10/base/metrics/statistics_recor...
File base/metrics/statistics_recorder.h (right):

http://codereview.chromium.org/10703037/diff/10/base/metrics/statistics_recor...
base/metrics/statistics_recorder.h:15: #include <map>
nit: alphabetize

[kaiwang, 2012-07-03 00:22:22]

http://codereview.chromium.org/10703037/diff/10/base/metrics/statistics_recor...
File base/metrics/statistics_recorder.h (right):

http://codereview.chromium.org/10703037/diff/10/base/metrics/statistics_recor...
base/metrics/statistics_recorder.h:15: #include <map>
On 2012/07/02 23:59:15, jar wrote:
> nit: alphabetize

Done.

[kaiwang, 2012-07-10 02:34:39]

Move StatisticsRecorder out of histogram.cc/h for further refactoring.

[kaiwang, 2012-07-11 01:58:39]

Move StatisticsRecorder out of histogram.cc/h for further refactoring.

[kaiwang, 2012-07-12 00:57:05]

Hi jam, this is a simple change to move StatisticsRecorder to a new file. Since
I have touched files under chrome/ and content/, could you take a look? Thanks a
lot!

[jochen (gone - plz use gerrit), 2012-07-12 09:24:04]

lgtm

[jam, 2012-07-12 18:58:10]

content lgtm, you don't need my review for chrome (otehr reviewers are enough)

[commit-bot: I haz the power, 2012-07-12 19:21:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10703037/5082

[commit-bot: I haz the power, 2012-07-12 19:21:57]

Failed to apply patch for base/base.gypi:
While running patch -p0 --forward --force;
patching file base/base.gypi
Hunk #1 FAILED at 235.
1 out of 1 hunk FAILED -- saving rejects to file base/base.gypi.rej

[commit-bot: I haz the power, 2012-07-12 21:04:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10703037/5082

[commit-bot: I haz the power, 2012-07-12 21:04:41]

Failed to apply patch for base/base.gypi:
While running patch -p0 --forward --force;
patching file base/base.gypi
Hunk #1 FAILED at 235.
1 out of 1 hunk FAILED -- saving rejects to file base/base.gypi.rej

[jar (doing other things), 2012-07-12 23:39:55]

lgtm

[kaiwang, 2012-07-13 01:25:34]

Seems I need more LGTMs...

[mattm, 2012-07-13 01:46:28]

safe_browsing/ lgtm.   (I assume that's what I was added for?  In the future you
could specify which dirs each review should look at.)

[kaiwang, 2012-07-13 02:38:43]

Thanks! I still need approval for:

    chrome/browser/ui
    chrome/browser/ui/webui
    chrome/browser/protector

[Ivan Korotkov, 2012-07-13 08:13:15]

protector/ LGTM

[Peter Kasting, 2012-07-13 19:35:46]

chrome/browser/ui/* LGTM

[commit-bot: I haz the power, 2012-07-13 19:56:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10703037/5089

[commit-bot: I haz the power, 2012-07-13 21:48:31]

Change committed as 146659