Doc: Use explicit linkage with target_link_libraries

The Professional CMake book suggests always using explicit linkage with
target_link_libraries, so let's use that.

Whether to use PUBLIC or PRIVATE depends on the context. But let's
be conservative and advise on using PRIVATE by default.

Task-number: QTBUG-88935
Pick-to: 6.0
Change-Id: I12b80ee85be9f6916f1e4dea6b1c9cb29e03c20f
Reviewed-by: Craig Scott <[email protected]>
Reviewed-by: Alexandru Croitor <[email protected]>

11 files changed, 11 insertions, 11 deletions

diff --git a/src/concurrent/doc/snippets/CMakeLists.txt b/src/concurrent/doc/snippets/CMakeLists.txt
index 35be339f317..ffbf3014c92 100644
--- a/src/concurrent/doc/snippets/CMakeLists.txt
+++ b/src/concurrent/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS Concurrent REQUIRED)
-target_link_libraries(mytarget Qt6::Concurrent)
+target_link_libraries(mytarget PRIVATE Qt6::Concurrent)
 #! [cmake_use]
diff --git a/src/corelib/doc/snippets/overview/using-qt-core.cmake b/src/corelib/doc/snippets/overview/using-qt-core.cmake
index b5689d803dc..a2c2034b8ba 100644
--- a/src/corelib/doc/snippets/overview/using-qt-core.cmake
+++ b/src/corelib/doc/snippets/overview/using-qt-core.cmake
@@ -1,2 +1,2 @@
 find_package(Qt6 COMPONENTS Core REQUIRED)
-target_link_libraries(mytarget Qt6::Core)
+target_link_libraries(mytarget PRIVATE Qt6::Core)
diff --git a/src/dbus/doc/snippets/CMakeLists.txt b/src/dbus/doc/snippets/CMakeLists.txt
index 87c7990972a..825a088019d 100644
--- a/src/dbus/doc/snippets/CMakeLists.txt
+++ b/src/dbus/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS DBus REQUIRED)
-target_link_libraries(mytarget Qt6::DBus)
+target_link_libraries(mytarget PRIVATE Qt6::DBus)
 #! [cmake_use]
diff --git a/src/gui/doc/snippets/overview/using-qt-gui.cmake b/src/gui/doc/snippets/overview/using-qt-gui.cmake
index 687a83a2d06..65a3f9034a4 100644
--- a/src/gui/doc/snippets/overview/using-qt-gui.cmake
+++ b/src/gui/doc/snippets/overview/using-qt-gui.cmake
@@ -1,2 +1,2 @@
 find_package(Qt6 COMPONENTS Gui REQUIRED)
-target_link_libraries(mytarget Qt6::Gui)
+target_link_libraries(mytarget PRIVATE Qt6::Gui)
diff --git a/src/network/doc/snippets/CMakeLists.txt b/src/network/doc/snippets/CMakeLists.txt
index 2936484f197..2ae4c75a1b9 100644
--- a/src/network/doc/snippets/CMakeLists.txt
+++ b/src/network/doc/snippets/CMakeLists.txt
@@ -8,5 +8,5 @@ add_executable(mytarget
 
 # ![0]
 find_package(Qt6 COMPONENTS Network REQUIRED)
-target_link_libraries(mytarget Qt6::Network)
+target_link_libraries(mytarget PRIVATE Qt6::Network)
 # ![0]
diff --git a/src/opengl/doc/snippets/CMakeLists.txt b/src/opengl/doc/snippets/CMakeLists.txt
index 8ec6a4b83bf..28b641adfdd 100644
--- a/src/opengl/doc/snippets/CMakeLists.txt
+++ b/src/opengl/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS OpenGL REQUIRED)
-target_link_libraries(mytarget Qt6::OpenGL)
+target_link_libraries(mytarget PRIVATE Qt6::OpenGL)
 #! [cmake_use]
diff --git a/src/printsupport/doc/snippets/CMakeLists.txt b/src/printsupport/doc/snippets/CMakeLists.txt
index 6710a38db06..0a7f3b86fd2 100644
--- a/src/printsupport/doc/snippets/CMakeLists.txt
+++ b/src/printsupport/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS PrintSupport REQUIRED)
-target_link_libraries(mytarget Qt6::PrintSupport)
+target_link_libraries(mytarget PRIVATE Qt6::PrintSupport)
 #! [cmake_use]
diff --git a/src/sql/doc/snippets/CMakeLists.txt b/src/sql/doc/snippets/CMakeLists.txt
index bb300f425b6..2e74eed35ad 100644
--- a/src/sql/doc/snippets/CMakeLists.txt
+++ b/src/sql/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS Sql REQUIRED)
-target_link_libraries(mytarget Qt6::Sql)
+target_link_libraries(mytarget PRIVATE Qt6::Sql)
 #! [cmake_use]
diff --git a/src/testlib/doc/snippets/CMakeLists.txt b/src/testlib/doc/snippets/CMakeLists.txt
index c8ba7cc47a0..1dac3c91aa1 100644
--- a/src/testlib/doc/snippets/CMakeLists.txt
+++ b/src/testlib/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS Test REQUIRED)
-target_link_libraries(mytarget Qt6::Test)
+target_link_libraries(mytarget PRIVATE Qt6::Test)
 #! [cmake_use]
diff --git a/src/widgets/doc/snippets/CMakeLists.txt b/src/widgets/doc/snippets/CMakeLists.txt
index 1ba55ccb3b0..ebf9b38dc29 100644
--- a/src/widgets/doc/snippets/CMakeLists.txt
+++ b/src/widgets/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS Widgets REQUIRED)
-target_link_libraries(mytarget Qt6::Widgets)
+target_link_libraries(mytarget PRIVATE Qt6::Widgets)
 #! [cmake_use]
diff --git a/src/xml/doc/snippets/CMakeLists.txt b/src/xml/doc/snippets/CMakeLists.txt
index 18b7eaf266c..134f6c25895 100644
--- a/src/xml/doc/snippets/CMakeLists.txt
+++ b/src/xml/doc/snippets/CMakeLists.txt
@@ -1,4 +1,4 @@
 #! [cmake_use]
 find_package(Qt6 COMPONENTS Xml REQUIRED)
-target_link_libraries(mytarget Qt6::Xml)
+target_link_libraries(mytarget PRIVATE Qt6::Xml)
 #! [cmake_use]