summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <[email protected]>2024-03-28 10:11:07 +0100
committerQt Cherry-pick Bot <[email protected]>2024-04-28 05:42:30 +0000
commit13c7faec0e19f8985e4783040f20a570c6232597 (patch)
tree6e9d43fa4d9aabdf1605f9579fc85d3488f0421a
parent4019ec732a0a5a149d5b9917bd0e3923f11bb6db (diff)
androiddeplyqt: fix missing pclose() on early return
Found by Coverity. Amends 5bb178c479a247720fbc3fbb7f06a32b725193ac. Pick-to: 6.2 5.15 Coverity-Id: 378357 Change-Id: I8839280ce15d8e7d9e1f4024ca796c2d8b4ed930 Reviewed-by: BogDan Vatra <[email protected]> (cherry picked from commit c64b30129d7c6c7f99b6abc3f42d32fb61e27f76) Reviewed-by: Qt Cherry-pick Bot <[email protected]> (cherry picked from commit 950123bfbc063998e6019d427d3dde600e7d51dd)
-rw-r--r--src/tools/androiddeployqt/main.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tools/androiddeployqt/main.cpp b/src/tools/androiddeployqt/main.cpp
index bbb36d7fab8..87caa56e206 100644
--- a/src/tools/androiddeployqt/main.cpp
+++ b/src/tools/androiddeployqt/main.cpp
@@ -2037,6 +2037,7 @@ QStringList getQtLibsFromElf(const Options &options, const QString &fileName)
if (it == elfArchitectures.constEnd() || *it != options.currentArchitecture.toLatin1()) {
if (options.verbose)
fprintf(stdout, "Skipping \"%s\", architecture mismatch\n", qPrintable(fileName));
+ pclose(readElfCommand);
return {};
}
}