summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <[email protected]>2023-08-02 19:30:14 +0200
committerMarc Mutz <[email protected]>2023-08-09 20:53:54 +0200
commit3ea8e8aef0aa0e2aa7d37eb95d422915c89f6fe6 (patch)
tree41623bb93db4384db2691ef0a1f5994416a4dd01
parenta6b7a613c79b94efe4908eb161b419e34ee46224 (diff)
QHostInfo: de-inline -Result and -Runnable dtors
These classes are not exported, so we don't run into duplicate vtables here, but the header is included in a few TUs other than qhostinfo.cpp (all, when building with PCH), so make sure we compile dtors only once. Change-Id: I51f6a6d27fc084ad469f82dc7aef3327bdd9a906 Reviewed-by: Ivan Solovev <[email protected]> Reviewed-by: Thiago Macieira <[email protected]> Reviewed-by: Qt CI Bot <[email protected]> (cherry picked from commit a2c8524ad7dd59f31b400b5da8979138dc835fcc) Reviewed-by: Fabian Kosmale <[email protected]>
-rw-r--r--src/network/kernel/qhostinfo.cpp6
-rw-r--r--src/network/kernel/qhostinfo_p.h4
2 files changed, 10 insertions, 0 deletions
diff --git a/src/network/kernel/qhostinfo.cpp b/src/network/kernel/qhostinfo.cpp
index d15c4f27ca1..3e1b019a93e 100644
--- a/src/network/kernel/qhostinfo.cpp
+++ b/src/network/kernel/qhostinfo.cpp
@@ -72,6 +72,9 @@ Q_APPLICATION_STATIC(QHostInfoLookupManager, theHostInfoLookupManager)
}
+QHostInfoResult::~QHostInfoResult()
+ = default;
+
/*
The calling thread is likely the one that executes the lookup via
QHostInfoRunnable. Unless we operate with a queued connection already,
@@ -818,6 +821,9 @@ QHostInfoRunnable::QHostInfoRunnable(const QString &hn, int i, const QObject *re
setAutoDelete(true);
}
+QHostInfoRunnable::~QHostInfoRunnable()
+ = default;
+
// the QHostInfoLookupManager will at some point call this via a QThreadPool
void QHostInfoRunnable::run()
{
diff --git a/src/network/kernel/qhostinfo_p.h b/src/network/kernel/qhostinfo_p.h
index 6b755ab0c2c..88e8c774296 100644
--- a/src/network/kernel/qhostinfo_p.h
+++ b/src/network/kernel/qhostinfo_p.h
@@ -51,6 +51,8 @@ public:
moveToThread(receiver->thread());
}
+ ~QHostInfoResult() override;
+
void postResultsReady(const QHostInfo &info);
Q_SIGNALS:
@@ -143,6 +145,8 @@ class QHostInfoRunnable : public QRunnable
public:
QHostInfoRunnable(const QString &hn, int i, const QObject *receiver,
QtPrivate::QSlotObjectBase *slotObj);
+ ~QHostInfoRunnable() override;
+
void run() override;
QString toBeLookedUp;