summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <[email protected]>2025-02-28 10:42:17 +0100
committerMarc Mutz <[email protected]>2025-02-28 18:30:39 +0100
commit58b9250aea0b1b41c8cbd1033149371a93a5b2c1 (patch)
treec880778a240f9541bffa747f7e2d3f7e53b4c4a8
parent9d78275f229f4ed26817c549bf1d8ef73ce371e3 (diff)
Init QWidget::data to nullptr
It's unconditionally set to &d->data in d->init(), but at least Coverity doesn't see it as that. Turn a potential uninit'ed value access into a proper nullptr deref, in case Coverity has a point. Not picking to older branches (at least not yet) in the unlikely case that this unearths something. Coverity-Id: 390797 Coverity-Id: 390790 Coverity-Id: 390785 Coverity-Id: 390783 Coverity-Id: 390775 Coverity-Id: 390774 Coverity-Id: 390771 Coverity-Id: 390765 Coverity-Id: 390762 Coverity-Id: 390751 Coverity-Id: 390737 Coverity-Id: 390734 Coverity-Id: 390727 Coverity-Id: 390724 Coverity-Id: 390707 Coverity-Id: 390706 Coverity-Id: 390700 Coverity-Id: 390693 Coverity-Id: 390692 Coverity-Id: 390690 Coverity-Id: 390684 Coverity-Id: 390680 Coverity-Id: 390677 Coverity-Id: 390675 Coverity-Id: 390669 Coverity-Id: 390662 Coverity-Id: 390660 Coverity-Id: 390659 Coverity-Id: 390657 Change-Id: Ieba218117d4bfdb4cdf5069211e9d12517b26d24 Reviewed-by: Volker Hilsheimer <[email protected]>
-rw-r--r--src/widgets/kernel/qwidget.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/widgets/kernel/qwidget.h b/src/widgets/kernel/qwidget.h
index faf2b31a832..7dd767b033f 100644
--- a/src/widgets/kernel/qwidget.h
+++ b/src/widgets/kernel/qwidget.h
@@ -781,7 +781,7 @@ private:
Q_PRIVATE_SLOT(d_func(), void _q_showIfNotHidden())
Q_PRIVATE_SLOT(d_func(), QWindow *_q_closestWindowHandle())
- QWidgetData *data;
+ QWidgetData *data = nullptr; // init'ed in Private::init(), but let's crash before that
};
Q_DECLARE_OPERATORS_FOR_FLAGS(QWidget::RenderFlags)