summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVolker Hilsheimer <[email protected]>2022-10-23 11:57:17 +0200
committerVolker Hilsheimer <[email protected]>2022-10-25 05:16:15 +0200
commit6f9d31be493dfe72bd8332881b325f811c79523d (patch)
tree2c95f9549f5eb375d93588222aa84f2c75ee893c
parent273b13dbd151477d46a642a06e62c6029edd7e15 (diff)
Baseline: add stylesheet setting show-decoration-selected for treeview
The fix for QTBUG-73251 in f4976f86cd265d7505da449dafe15c51e3c8cdc0 resulted in QTBUG-106227. Add baseline test coverage for the respective configuration to make sure we don't regress. Refactor mapping of index to configuration to make accessing of subitems more robust. Task-number: QTBUG-73251 Pick-to: 6.4 6.2 Change-Id: I530ecd67fa5663f219884f641bc5e25c7ac5fe73 Reviewed-by: Shawn Rutledge <[email protected]> Reviewed-by: Axel Spoerl <[email protected]>
-rw-r--r--tests/baseline/stylesheet/qss/qtreeview/showDecorationSelected.qss3
-rw-r--r--tests/baseline/stylesheet/tst_baseline_stylesheet.cpp29
2 files changed, 24 insertions, 8 deletions
diff --git a/tests/baseline/stylesheet/qss/qtreeview/showDecorationSelected.qss b/tests/baseline/stylesheet/qss/qtreeview/showDecorationSelected.qss
new file mode 100644
index 00000000000..b279b587bd2
--- /dev/null
+++ b/tests/baseline/stylesheet/qss/qtreeview/showDecorationSelected.qss
@@ -0,0 +1,3 @@
+QTreeView {
+ show-decoration-selected: 1
+}
diff --git a/tests/baseline/stylesheet/tst_baseline_stylesheet.cpp b/tests/baseline/stylesheet/tst_baseline_stylesheet.cpp
index 11c82214433..3a4d8e8f15d 100644
--- a/tests/baseline/stylesheet/tst_baseline_stylesheet.cpp
+++ b/tests/baseline/stylesheet/tst_baseline_stylesheet.cpp
@@ -160,19 +160,29 @@ void tst_Stylesheet::tst_QTreeView()
tw->header()->hide();
layout->addWidget(tw);
- for (int i = 0; i < 6; ++i) {
+ enum {
+ Unchecked = 0,
+ Checked = 1,
+ Children = 2,
+ Disabled = 3,
+ CheckedDisabled = 4,
+ ChildrenDisabled = 5,
+ NConfigs
+ };
+
+ for (int i = 0; i < NConfigs; ++i) {
QTreeWidgetItem *topLevelItem = new QTreeWidgetItem(tw, QStringList{QString("top %1").arg(i)});
switch (i) {
- case 0:
- case 3:
+ case Unchecked:
+ case Disabled:
topLevelItem->setCheckState(0, Qt::Unchecked);
break;
- case 1:
- case 4:
+ case Checked:
+ case CheckedDisabled:
topLevelItem->setCheckState(0, Qt::Checked);
break;
- case 2:
- case 5:
+ case Children:
+ case ChildrenDisabled:
topLevelItem->setCheckState(0, Qt::PartiallyChecked);
topLevelItem->setExpanded(true);
for (int j = 0; j < 2; ++j) {
@@ -181,7 +191,7 @@ void tst_Stylesheet::tst_QTreeView()
}
break;
}
- topLevelItem->setDisabled(i > 2);
+ topLevelItem->setDisabled(i >= Disabled);
}
testWindow()->setLayout(layout);
tw->setRootIsDecorated(true);
@@ -190,6 +200,9 @@ void tst_Stylesheet::tst_QTreeView()
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootDecorated");
tw->setRootIsDecorated(false);
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootNotDecorated");
+
+ tw->topLevelItem(Children)->child(0)->setSelected(true);
+ QBASELINE_CHECK_DEFERRED(takeSnapshot(), "itemSelected");
}
#define main _realmain