Mark all qtbase headers that aren't clean

QtCore has a few headers that, though public, aren't meant to be
included directly. Those are the atomic headers, the three _impl.h
headers and qt_windows.h.

QtGui includes two OpenGL headers that don't compile on their own.

Other libraries should not have headers like that (but they do,
something we need to fix eventually).

Change-Id: I55e4eb057748f47df927ee618f9409acbc189cc1
Reviewed-by: Sean Harmer <[email protected]>
Reviewed-by: Gunnar Sletta <[email protected]>
Reviewed-by: Thiago Macieira <[email protected]>

27 files changed, 105 insertions, 0 deletions

diff --git a/src/corelib/arch/qatomic_alpha.h b/src/corelib/arch/qatomic_alpha.h
index c5657de9a8d..71cb112d479 100644
--- a/src/corelib/arch/qatomic_alpha.h
+++ b/src/corelib/arch/qatomic_alpha.h
@@ -46,6 +46,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_armv5.h b/src/corelib/arch/qatomic_armv5.h
index 92e2b02e5bd..e0a50b3c245 100644
--- a/src/corelib/arch/qatomic_armv5.h
+++ b/src/corelib/arch/qatomic_armv5.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_armv6.h b/src/corelib/arch/qatomic_armv6.h
index 877d32af8b8..7f5939e3916 100644
--- a/src/corelib/arch/qatomic_armv6.h
+++ b/src/corelib/arch/qatomic_armv6.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_armv7.h b/src/corelib/arch/qatomic_armv7.h
index 70dc24f8079..1929ae0ab3b 100644
--- a/src/corelib/arch/qatomic_armv7.h
+++ b/src/corelib/arch/qatomic_armv7.h
@@ -57,6 +57,9 @@
 QT_BEGIN_NAMESPACE
 
 QT_END_NAMESPACE
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
 #endif
 
 #endif // QATOMIC_ARMV7_H
diff --git a/src/corelib/arch/qatomic_bfin.h b/src/corelib/arch/qatomic_bfin.h
index 9791d808188..79519308a48 100644
--- a/src/corelib/arch/qatomic_bfin.h
+++ b/src/corelib/arch/qatomic_bfin.h
@@ -46,6 +46,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_NOT_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_bootstrap.h b/src/corelib/arch/qatomic_bootstrap.h
index 810d9de7228..160e0abdf35 100644
--- a/src/corelib/arch/qatomic_bootstrap.h
+++ b/src/corelib/arch/qatomic_bootstrap.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_cxx11.h b/src/corelib/arch/qatomic_cxx11.h
index d56e5823c83..3119edaf45d 100644
--- a/src/corelib/arch/qatomic_cxx11.h
+++ b/src/corelib/arch/qatomic_cxx11.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_gcc.h b/src/corelib/arch/qatomic_gcc.h
index 38fd73ff15c..bd296053e57 100644
--- a/src/corelib/arch/qatomic_gcc.h
+++ b/src/corelib/arch/qatomic_gcc.h
@@ -49,6 +49,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_ia64.h b/src/corelib/arch/qatomic_ia64.h
index f57b44bcfd5..d4b187ffea2 100644
--- a/src/corelib/arch/qatomic_ia64.h
+++ b/src/corelib/arch/qatomic_ia64.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_integrity.h b/src/corelib/arch/qatomic_integrity.h
index 307d9d51a76..f8cfc8ce5bf 100644
--- a/src/corelib/arch/qatomic_integrity.h
+++ b/src/corelib/arch/qatomic_integrity.h
@@ -47,6 +47,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define qt_i2addr(a) reinterpret_cast<Address *>(const_cast<int *>(a))
 #define qt_p2addr(a) reinterpret_cast<Address *>(const_cast<void *>(a))
 #define qt_addr(a) reinterpret_cast<Address>(a)
diff --git a/src/corelib/arch/qatomic_mips.h b/src/corelib/arch/qatomic_mips.h
index 51e33bee351..77167503326 100644
--- a/src/corelib/arch/qatomic_mips.h
+++ b/src/corelib/arch/qatomic_mips.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_msvc.h b/src/corelib/arch/qatomic_msvc.h
index 3d55471cb76..4f91e3d9da3 100644
--- a/src/corelib/arch/qatomic_msvc.h
+++ b/src/corelib/arch/qatomic_msvc.h
@@ -219,6 +219,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_power.h b/src/corelib/arch/qatomic_power.h
index 1be2b770a85..ad1c619d561 100644
--- a/src/corelib/arch/qatomic_power.h
+++ b/src/corelib/arch/qatomic_power.h
@@ -46,6 +46,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_s390.h b/src/corelib/arch/qatomic_s390.h
index 3e821107949..0469f44e5fd 100644
--- a/src/corelib/arch/qatomic_s390.h
+++ b/src/corelib/arch/qatomic_s390.h
@@ -46,6 +46,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_sh4a.h b/src/corelib/arch/qatomic_sh4a.h
index 75b9bed40bf..08f75e44f29 100644
--- a/src/corelib/arch/qatomic_sh4a.h
+++ b/src/corelib/arch/qatomic_sh4a.h
@@ -49,6 +49,11 @@ QT_BEGIN_NAMESPACE
 
 QT_END_NAMESPACE
 
+#if 0
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_sparc.h b/src/corelib/arch/qatomic_sparc.h
index 8508638d02e..8aea33ce85b 100644
--- a/src/corelib/arch/qatomic_sparc.h
+++ b/src/corelib/arch/qatomic_sparc.h
@@ -46,6 +46,15 @@
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #if defined(_LP64)
 
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
diff --git a/src/corelib/arch/qatomic_unix.h b/src/corelib/arch/qatomic_unix.h
index 3bf8fa82f1f..03c7d2eee83 100644
--- a/src/corelib/arch/qatomic_unix.h
+++ b/src/corelib/arch/qatomic_unix.h
@@ -49,6 +49,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/arch/qatomic_vxworks.h b/src/corelib/arch/qatomic_vxworks.h
index def5e24ff56..57e3b6a32b8 100644
--- a/src/corelib/arch/qatomic_vxworks.h
+++ b/src/corelib/arch/qatomic_vxworks.h
@@ -67,6 +67,15 @@ inline int taskUnlock() { return 0; }
 
 QT_BEGIN_NAMESPACE
 
+#if 0
+// silence syncqt warnings
+QT_END_NAMESPACE
+QT_END_HEADER
+
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #define Q_ATOMIC_INT_REFERENCE_COUNTING_IS_NOT_NATIVE
 
 inline bool QBasicAtomicInt::isReferenceCountingNative()
diff --git a/src/corelib/arch/qatomic_x86.h b/src/corelib/arch/qatomic_x86.h
index 543b2e056c8..f8180ad9d62 100644
--- a/src/corelib/arch/qatomic_x86.h
+++ b/src/corelib/arch/qatomic_x86.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/global/qt_windows.h b/src/corelib/global/qt_windows.h
index 26b55336ed4..c3266c54879 100644
--- a/src/corelib/global/qt_windows.h
+++ b/src/corelib/global/qt_windows.h
@@ -42,6 +42,11 @@
 #ifndef QT_WINDOWS_H
 #define QT_WINDOWS_H
 
+#if 0
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 #if defined(Q_CC_BOR)
 // Borland's windows.h does not set these correctly, resulting in
 // unusable WinSDK standard dialogs
diff --git a/src/corelib/kernel/qobject_impl.h b/src/corelib/kernel/qobject_impl.h
index e6f924814dd..0b5631f2a6c 100644
--- a/src/corelib/kernel/qobject_impl.h
+++ b/src/corelib/kernel/qobject_impl.h
@@ -45,6 +45,11 @@
 #error Do not include qobject_impl.h directly
 #endif
 
+#if 0
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 QT_BEGIN_NAMESPACE
 
 
diff --git a/src/corelib/kernel/qobjectdefs_impl.h b/src/corelib/kernel/qobjectdefs_impl.h
index 2d2107f666c..8d85175a177 100644
--- a/src/corelib/kernel/qobjectdefs_impl.h
+++ b/src/corelib/kernel/qobjectdefs_impl.h
@@ -45,6 +45,11 @@
 #error Do not include qobjectdefs_impl.h directly
 #endif
 
+#if 0
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
 QT_BEGIN_NAMESPACE
 
 
diff --git a/src/corelib/thread/qgenericatomic.h b/src/corelib/thread/qgenericatomic.h
index a8d626a43f1..a0a851eabbb 100644
--- a/src/corelib/thread/qgenericatomic.h
+++ b/src/corelib/thread/qgenericatomic.h
@@ -49,6 +49,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/corelib/thread/qoldbasicatomic.h b/src/corelib/thread/qoldbasicatomic.h
index 220dade8500..b755256ff75 100644
--- a/src/corelib/thread/qoldbasicatomic.h
+++ b/src/corelib/thread/qoldbasicatomic.h
@@ -50,6 +50,7 @@ QT_BEGIN_NAMESPACE
 #if 0
 // silence syncqt warnings
 QT_END_NAMESPACE
+#pragma qt_sync_skip_header_check
 #pragma qt_no_master_include
 #pragma qt_sync_stop_processing
 #endif
diff --git a/src/corelib/tools/qsharedpointer_impl.h b/src/corelib/tools/qsharedpointer_impl.h
index 3121bcdf40f..5e30cf3ecb6 100644
--- a/src/corelib/tools/qsharedpointer_impl.h
+++ b/src/corelib/tools/qsharedpointer_impl.h
@@ -46,6 +46,11 @@
 #endif
 
 #if 0
+#pragma qt_sync_skip_header_check
+#pragma qt_sync_stop_processing
+#endif
+
+#if 0
 // These macros are duplicated here to make syncqt not complain a about
 // this header, as we have a "qt_sync_stop_processing" below, which in turn
 // is here because this file contains a template mess and duplicates the
diff --git a/src/gui/opengl/qopengles2ext.h b/src/gui/opengl/qopengles2ext.h
index 61bfb595ccc..6213fab344d 100644
--- a/src/gui/opengl/qopengles2ext.h
+++ b/src/gui/opengl/qopengles2ext.h
@@ -3,6 +3,7 @@
 
 #if 0
 #pragma qt_no_master_include
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif
 
diff --git a/src/gui/opengl/qopenglext.h b/src/gui/opengl/qopenglext.h
index 68025f3e5c3..e65578caee6 100644
--- a/src/gui/opengl/qopenglext.h
+++ b/src/gui/opengl/qopenglext.h
@@ -3,6 +3,7 @@
 
 #if 0
 #pragma qt_no_master_include
+#pragma qt_sync_skip_header_check
 #pragma qt_sync_stop_processing
 #endif