Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 69953008: Save execution phase of the browser to prefs file whenever we set the (Closed)

Created:
7 years, 1 month ago by ramant (doing other things)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Save execution phase of the browser to prefs file whenever we set the execution_phase. Minor cleanup: Added SHUTDOWN_COMPLETE to the execution_phase. Renamed CLEAN_SHUTDOWN to UNINITIALIZED_PHASE. Added Chrome.Browser.CrashedExecutionPhase histogram to reflect changes to execution phase enums. Retired Chrome.Browser.ExecutionPhase histogram. R=jar@chromium.org, Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235118

Patch Set 1 #

Patch Set 2 : Added new Histogram to reflect execution_phase changes #

Patch Set 3 : Fix the unit tests #

Patch Set 4 : Merge with tip-of-tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 8 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
ramant (doing other things)
7 years, 1 month ago (2013-11-12 23:46:55 UTC) #1
ramant (doing other things)
PTAL.
7 years, 1 month ago (2013-11-13 00:43:43 UTC) #2
jar (doing other things)
LGTM.... but be sure the bots are OK.
7 years, 1 month ago (2013-11-13 20:48:06 UTC) #3
ramant (doing other things)
7 years, 1 month ago (2013-11-13 23:24:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/69953008/480001
7 years, 1 month ago (2013-11-13 23:41:39 UTC) #5
ramant (doing other things)
Hi Nico, Would appreciate if you could review this CL (jar is not an OWNER ...
7 years, 1 month ago (2013-11-14 00:16:19 UTC) #6
Nico
lgtm Sorry, didn't realize that.
7 years, 1 month ago (2013-11-14 00:18:36 UTC) #7
ramant (doing other things)
On 2013/11/14 00:18:36, Nico wrote: > lgtm > > Sorry, didn't realize that. Awesome. Thanks ...
7 years, 1 month ago (2013-11-14 00:19:53 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36089
7 years, 1 month ago (2013-11-14 00:24:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/69953008/740001
7 years, 1 month ago (2013-11-14 00:50:21 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=101637
7 years, 1 month ago (2013-11-14 01:53:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/69953008/740001
7 years, 1 month ago (2013-11-14 03:41:30 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 11:02:23 UTC) #13
Message was sent while issue was closed.
Change committed as 235118

Powered by Google App Engine
This is Rietveld 408576698