Show the network interface with highest priority (aka lower metric) #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should check why we introduced that condition with this commit. |
|
If I'm not wrong like you are the author of that modification right 😃. However at the moment is broken as it doesn't show the interface which is effectively used |
|
Yep, but i don't remember why :D |
|
did we release this fix? I still don't see my LAN to get the priority, instead it's always WIFI... EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On new interface discovery a new index is (may be) assigned to the
temp_idx.The new interface should be assigned to
netif is the first one (net->ifid_ == -1) or if has higher priority (priority < net->route_priority... lower is higher according to metric).This PR removes the additional condition
net->ifid_ != temp_idxwhich is always be true and incorrectly ends up showing the last found route instead of the one with higher priorityCloses #2167