#4237 BT metricscaler - Filter cpu query to get the metrics for the correct resources#4238
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@GoogleCloudPlatform/bigtable-dpe for review |
|
Hey @odedfos - it looks like our CI/CD is failing with this error: Could you take a look and see how to resolve it? |
…to get the metrics for the correct resources
|
I've fixed the failing tests |
|
Hi @odedfos - sorry for delay. CI is passing, but lint is failing - I'll fix those lint errors for you and get this merged asap. Sorry for the delay! Thanks @billyjacobson for the review :) |
|
This 3.7 failure seems like a fluke - I'm rerunning to see what happens |
|
Thanks @leahecole for helping to get this in! |
…orrect resources [(#4238)](GoogleCloudPlatform/python-docs-samples#4238) * #4237 Added a filter to the cpu & storage queries to get the metrics for the correct resources * fix lint * fix lint again Co-authored-by: Leah E. Cole <[email protected]> Co-authored-by: Leah Cole <[email protected]>
Description
Fixes #4237
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Enviroment Setup)nox -s lint(see Test Enviroment Setup)