-
Notifications
You must be signed in to change notification settings - Fork 563
Move Barren handling to before hint generation, Add RandomizerArea enum and other cleanups #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leggettc18
merged 10 commits into
HarbourMasters:develop-rando
from
Pepper0ni:MoveBarren
Dec 7, 2023
Merged
Move Barren handling to before hint generation, Add RandomizerArea enum and other cleanups #3339
leggettc18
merged 10 commits into
HarbourMasters:develop-rando
from
Pepper0ni:MoveBarren
Dec 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
026037b
to
cdf8cb6
Compare
61a8bbe
to
f9c9df3
Compare
f9c9df3
to
4ea4b50
Compare
Sorry I think I introduced some merge conflicts here. It shouldn't be anything too major. Mostly just some semantic correctness stuff rather than any functionality changes. |
leggettc18
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I see a few things here that should be changed but nothing major.
leggettc18
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full changelist
Build Artifacts