Skip to content

Implement "Move While First Person" enhancement #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

Implement "Move While First Person" enhancement #3340

merged 2 commits into from
Dec 20, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Oct 27, 2023 •
edited by github-actions bot
Loading

This enhancement requires gRightStickAiming to be enabled.

Most of the diff here is cleaning up func_8084ABD8, I have split the commits up to differentiate the cleanup from my changes here

Untitled.mov

Build Artifacts

@garrettjoecox garrettjoecox added the do not merge Not ready or not valid changes label Oct 27, 2023
@garrettjoecox garrettjoecox force-pushed the gMoveWhileFirstPerson branch 4 times, most recently from b7bda0d to 2d4fafc Compare October 28, 2023 15:51
@garrettjoecox garrettjoecox removed the do not merge Not ready or not valid changes label Nov 2, 2023
@garrettjoecox
Copy link
Contributor Author

Removed the do not merge badge, still not sure if this is something we want to support, open to feedback

@garrettjoecox garrettjoecox force-pushed the gMoveWhileFirstPerson branch 2 times, most recently from 275d25c to 3ee340f Compare December 2, 2023 05:57
@garrettjoecox
Copy link
Contributor Author

garrettjoecox commented Dec 2, 2023 •
edited
Loading

Alright this is ready for another look.

  • Split up the commits so you can see my changes separate from cleanup
  • Got movement working precisely as it should, including accounting for collision
  • Calling footstep sound method (using a magic number here but it's to approximate how my distance change converts to what's normally linear velocity)

briaguya-ai
briaguya-ai approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should get this in as a "rebase and merge" instead of squash because having this split into 2 commits makes it super easy to understand!

@garrettjoecox garrettjoecox merged commit 2cb3a36 into HarbourMasters:develop Dec 20, 2023
@garrettjoecox garrettjoecox deleted the gMoveWhileFirstPerson branch March 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettjoecox @briaguya-ai